-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intersection points #164
Intersection points #164
Conversation
src/methods/clipping/intersection.jl
Outdated
line_orient == line_out && continue | ||
pt1, _ = intr1 | ||
push!(result, pt1) | ||
if line_orient == line_over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to check line_cross or line_hinge any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I will add comments, but if it is line_cross
and line_hinge
(and line_over
), then we know there is one intersection point. Then, if it is line_over
, we know that there is a second intersection points. This isn't true with line_hinge
and line_cross
.
Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>
Before, the
intersection_points
function just skipped degenerate intersection points. This might not be the most performant way to do this due to theunique!
call, but at least it is more correct than the previous version.If approved, I can also do a patch version bump.