Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ecosystem integration tests #160

Merged
merged 5 commits into from
Sep 19, 2023
Merged

add ecosystem integration tests #160

merged 5 commits into from
Sep 19, 2023

Conversation

rafaqz
Copy link
Member

@rafaqz rafaqz commented Sep 19, 2023

This PR adds a downstream integration script to CI that will check packages that use GDAL with every pull request.

There will be a GROUP=GDAL environment variable available and tested package should use it to limit tests to only those effected by GDAL to cut the time CI here will take. For e.g. ArchGDAL.jl that may be all tests, for Rasters.jl it will be 10%. etc.

Please comment now or PR later to add packages that should be tested.

@visr
Copy link
Member

visr commented Sep 19, 2023

Nice! Can you remove or edit IntegrationTest.yml from #154? No need to test ArchGDAL twice.

@rafaqz
Copy link
Member Author

rafaqz commented Sep 19, 2023

Haha didn't know about that one. Yes this is just a more generic way to do that, I'll remove it.

@rafaqz
Copy link
Member Author

rafaqz commented Sep 19, 2023

My GDAL was a few commits behind and I didn't have that file yet, didn't mean to step on toes here!

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise this is good to go.

.github/workflows/Integrations.yml Outdated Show resolved Hide resolved
Co-authored-by: Martijn Visser <mgvisser@gmail.com>
@evetion evetion merged commit a48dae1 into master Sep 19, 2023
14 of 15 checks passed
@visr visr deleted the integration_tests branch October 6, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants