Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test all downstream packages automatically #144

Closed
evetion opened this issue Dec 30, 2022 · 2 comments · Fixed by #154
Closed

Test all downstream packages automatically #144

evetion opened this issue Dec 30, 2022 · 2 comments · Fixed by #154

Comments

@evetion
Copy link
Member

evetion commented Dec 30, 2022

Given the recent discussion and breakage in yeesian/ArchGDAL.jl#354.

Even with no breaking changes in GDAL.jl itself, new GDAL_jll versions can sometimes break downstream APIs.
@yeesian
Copy link
Member

yeesian commented Dec 30, 2022

I guess it's a case of https://www.hyrumslaw.com/ haha

@visr
Copy link
Member

visr commented Dec 30, 2022

Would be good to have this. Fixing yeesian/ArchGDAL.jl#158 could help reduce noise as well. So as mentioned in the other issue let's use these downstream tests also to judge whether new GDAL_jll versions need to be released as breaking GDAL.jl releases. The current GDAL.jl 1.5 should really have been GDAL.jl 2.0 if we want to take semver seriously.

visr added a commit that referenced this issue Jun 2, 2023
@visr
Run downstream tests: ArchGDAL
936ea4d 
Since ArchGDAL has much more extensive tests, this will catch more issues. Fixes #144.

Also adds dependabot to keep the GitHub Actions up to date, as done here: SciML/MuladdMacro.jl#37
@visr visr mentioned this issue Jun 2, 2023
Merged
@visr visr closed this as completed in #154 Jun 13, 2023
visr added a commit that referenced this issue Jun 13, 2023
@visr
Run downstream tests: ArchGDAL (#154)
e5dc2dc 
Since ArchGDAL has much more extensive tests, this will catch more issues. Fixes #144.

Also adds dependabot to keep the GitHub Actions up to date, as done here: SciML/MuladdMacro.jl#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run downstream tests: ArchGDAL JuliaGeo/GDAL.jl
3 participants
@yeesian @visr @evetion