Close STDIN to prevent git from prompting for username/password #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, make the test with the non-existing repo more robust: GitHub doesn't allow `!` in repo names, so trying to clone `DOES_NOT_EXIST!!!.jl` would fail immediately anyway. Instead we want to test that trying to clone a repo with a valid name doesn't prompt for username/password.
giordano
force-pushed
the
mg/credential-helper
branch
from
b98381f
to
d577988
Compare
giordano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make the test with the non-existing repo more robust: GitHub doesn't allow
!in repo names, so trying to cloneDOES_NOT_EXIST!!!.jlwould failimmediately anyway. Instead we want to test that trying to clone a repo with a
valid name doesn't prompt for username/password.