Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Remove type parameters for SharedStatsStep and PooledStatsProcedure #9

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

junyuan-chen
Copy link
Member

pool seems to be faster now.

Additionally, adding @inline helps the performance of coef and vcov when getting indices based on the rows in treatinds.

@junyuan-chen junyuan-chen added the performance Enhancement of performance label Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #9 (f88411c) into master (11ff4aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           8        8           
  Lines         503      506    +3     
=======================================
+ Hits          501      504    +3     
  Misses          2        2           
Impacted Files Coverage Δ
src/StatsProcedures.jl 99.19% <100.00%> (+<0.01%) ⬆️
src/did.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ff4aa...64a9214. Read the comment docs.

@junyuan-chen junyuan-chen merged commit e653da5 into master Feb 19, 2021
@junyuan-chen junyuan-chen deleted the pr/perf branch February 19, 2021 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
performance Enhancement of performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant