Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Return example data as VecColumnTable with Vector columns #29

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

junyuan-chen
Copy link
Member

The columns of type SentinelArrays.ChainedVector contained in CSV.File are no longer suitable for directly working with FixedEffect due to the customized behavior of eachindex. They need to be converted to Vectors.

@junyuan-chen junyuan-chen added the enhancement New feature or request label Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #29 (0f3cccd) into master (7ccedad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          12       12           
  Lines        1338     1342    +4     
=======================================
+ Hits         1336     1340    +4     
  Misses          2        2           
Impacted Files Coverage Δ
src/DiffinDiffsBase.jl 100.00% <ø> (ø)
src/StatsProcedures.jl 99.30% <ø> (ø)
src/operations.jl 100.00% <100.00%> (ø)
src/utils.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ccedad...0f3cccd. Read the comment docs.

@junyuan-chen junyuan-chen merged commit a2bce2b into master Jun 7, 2021
@junyuan-chen junyuan-chen deleted the pr/exampledata branch June 7, 2021 04:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant