Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Add ScaledArray, RotatingTimeValue and settime #23

Merged
merged 5 commits into from
Apr 15, 2021
Merged

Conversation

junyuan-chen
Copy link
Member

@junyuan-chen junyuan-chen commented Apr 11, 2021

  1. The new array type ScaledArray is helpful for working with time data that are not integers. Otherwise, it may not be clear which value represents the next time period.
  2. To allow working with rotating panels where the time periods may overlap across different rotation groups, RotatingTimeValue replaces the default integer reference values in ScaledArray. It can also be used as array index and supports some basic arithmetics.
  3. The new function settime is only necessary when the time data are not integers.

@junyuan-chen junyuan-chen added the enhancement New feature or request label Apr 11, 2021
@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #23 (f58d31d) into master (bba59a4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   99.81%   99.83%   +0.02%     
==========================================
  Files          10       11       +1     
  Lines        1053     1184     +131     
==========================================
+ Hits         1051     1182     +131     
  Misses          2        2              
Impacted Files Coverage Δ
src/DiffinDiffsBase.jl 100.00% <ø> (ø)
src/ScaledArrays.jl 100.00% <100.00%> (ø)
src/operations.jl 100.00% <100.00%> (ø)
src/parallels.jl 100.00% <100.00%> (ø)
src/procedures.jl 100.00% <100.00%> (ø)
src/utils.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba59a4...f58d31d. Read the comment docs.

@junyuan-chen junyuan-chen changed the title Add RotatingTimeValue and support for Dates Add ScaledArray, RotatingTimeValue and settime Apr 15, 2021
@junyuan-chen junyuan-chen merged commit fc03843 into master Apr 15, 2021
@junyuan-chen junyuan-chen deleted the pr/rotate branch April 15, 2021 05:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant