Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Add AbstractDIDResult with improved interface and subtypes #20

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

junyuan-chen
Copy link
Member

Several substantial changes/additions have been made:

  1. A new abstract type AbstractDIDResult provides common interface for all subtypes used to collect results.
  2. A new abstract type AggregatedDIDResult with related helper functions.
  3. A concrete type SubDIDResult for viewing into a subset of a AbstractDIDResult.
  4. Concrete types TransformedDIDResult and TransSubDIDResult for results obtained from linear transformation.
  5. New functions lincom and rescale for linearly transforming coefficient estimates.
  6. New functions apply, apply_and! and apply_and.
  7. A new matrix type TableIndexedMatrix.

@junyuan-chen junyuan-chen added the enhancement New feature or request label Mar 30, 2021
@junyuan-chen junyuan-chen changed the title Add AbstractDIDResult with improved interface and subtypes and TableIndexedMatrix Add AbstractDIDResult with improved interface and subtypes Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #20 (b36ee41) into master (888d6d4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   99.75%   99.78%   +0.03%     
==========================================
  Files          10       10              
  Lines         816      942     +126     
==========================================
+ Hits          814      940     +126     
  Misses          2        2              
Impacted Files Coverage Δ
src/DiffinDiffsBase.jl 100.00% <ø> (ø)
src/did.jl 100.00% <100.00%> (ø)
src/tables.jl 100.00% <100.00%> (ø)
src/utils.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888d6d4...b36ee41. Read the comment docs.

@junyuan-chen junyuan-chen merged commit b091be6 into master Mar 30, 2021
@junyuan-chen junyuan-chen deleted the pr/DIDResult_table branch March 30, 2021 23:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant