Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Allow sorting VecColumnTable and define TermSet as wrapped Set #19

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

junyuan-chen
Copy link
Member

Since the rows of VecColumnTable can be sorted now, there is no need to use Tables.MatrixTable. Although row-wise operations on VecColumnTable seem to be somewhat slower than those on Tables.MatrixTable, element types can be concrete and operations on each column are faster.

treatcells is now a VecColumnTable. coef and vcov methods are updated correspondingly.

Equality of terms should be based on == rather than object-id. Hence, TermSet should not be IdDict.

@junyuan-chen junyuan-chen added the enhancement New feature or request label Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #19 (91f0124) into master (7bed71e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   99.72%   99.75%   +0.02%     
==========================================
  Files          10       10              
  Lines         736      816      +80     
==========================================
+ Hits          734      814      +80     
  Misses          2        2              
Impacted Files Coverage Δ
src/DiffinDiffsBase.jl 100.00% <ø> (ø)
src/did.jl 100.00% <100.00%> (ø)
src/operations.jl 100.00% <100.00%> (ø)
src/tables.jl 100.00% <100.00%> (ø)
src/terms.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bed71e...91f0124. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant