This repository has been archived by the owner on Mar 11, 2022. It is now read-only.
Allow sorting VecColumnTable and define TermSet as wrapped Set #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the rows of
VecColumnTable
can be sorted now, there is no need to useTables.MatrixTable
. Although row-wise operations onVecColumnTable
seem to be somewhat slower than those onTables.MatrixTable
, element types can be concrete and operations on each column are faster.treatcells
is now aVecColumnTable
.coef
andvcov
methods are updated correspondingly.Equality of terms should be based on
==
rather thanobject-id
. Hence,TermSet
should not beIdDict
.