Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Improve StatsSpec and fix an issue with macro did #10

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

junyuan-chen
Copy link
Member

@junyuan-chen junyuan-chen commented Feb 20, 2021

StatsSpec now has only one type parameter.

@did no longer assumes StatsSpec and functions that prepare the arguments are in the Main module.

A new helper function _get_default is added for merging default values into the named tuple of arguments.

@junyuan-chen junyuan-chen added bug Something isn't working enhancement New feature or request labels Feb 20, 2021
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #10 (98f410a) into master (e653da5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           8        8           
  Lines         506      510    +4     
=======================================
+ Hits          504      508    +4     
  Misses          2        2           
Impacted Files Coverage Δ
src/StatsProcedures.jl 99.20% <100.00%> (+0.01%) ⬆️
src/did.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e653da5...6f8f34f. Read the comment docs.

@junyuan-chen junyuan-chen merged commit b3c99b2 into master Feb 20, 2021
@junyuan-chen junyuan-chen deleted the pr/StatsSpec branch February 20, 2021 01:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant