Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enabled ESLint curly rule #429

Merged
merged 2 commits into from
May 13, 2023
Merged

build: enabled ESLint curly rule #429

merged 2 commits into from
May 13, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Runs --fix to fix up violations.

JoshuaKGoldberg
JoshuaKGoldberg commented May 13, 2023
View reviewed changes
script/setup.js
success === false
? chalk.yellow("⚠️ " + warnText)
: chalk.green("✅ " + successText)
);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi @RNR1 - this is the nittiest of the nitpicks on my end 😄

@JoshuaKGoldberg JoshuaKGoldberg merged commit fbfa041 into main May 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-curly branch May 13, 2023 00:14
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for infra.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request May 13, 2023
Merged
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions
Copy link

🎉 This is included in version v1.27.82 🎉

The release is available on:

Cheers! 📦🚀

1 similar comment
@github-actions
Copy link

🎉 This is included in version v1.27.82 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request May 13, 2023
@allcontributors
docs: add joshuakgoldberg as a contributor for infra (#430)
b5caadc 
Adds @JoshuaKGoldberg as a contributor for infra.

This was requested by JoshuaKGoldberg [in this
comment](#429 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@JoshuaKGoldberg
Copy link
Owner Author

Testing: does all-contributors still complain if you have content before the request?

@all-contributors please add @JoshuaKGoldberg for audio

@allcontributors allcontributors bot mentioned this pull request May 13, 2023
Closed
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for a11y

Testing: does all-contributors still complain if you have content after the request?

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've updated the pull request to add @JoshuaKGoldberg! 🎉

@JoshuaKGoldberg
Copy link
Owner Author

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@all-contributors please add @JoshuaKGoldberg for a11y

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@JoshuaKGoldberg already contributed before to a11y

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 13, 2023
Closed
This was referenced Feb 17, 2024
Open
Open
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Sep 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Enable ESLint's curly rule
1 participant
@JoshuaKGoldberg