Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null pointer dereference in JoltPhysicsCollision::CollideGetAABB #35

Closed
khang06 opened this issue Aug 30, 2022 · 4 comments · Fixed by #38
Closed

Null pointer dereference in JoltPhysicsCollision::CollideGetAABB #35

khang06 opened this issue Aug 30, 2022 · 4 comments · Fixed by #38
Milestone

Comments

@khang06
Copy link

khang06 commented Aug 30, 2022

I get a crash when I load gm_fork on GMod.
image

Looks like the crash is on this line.

Right before the crash, this gets logged:
Skipped solid 0 due to invalid header (id: 0\x1A\x89?, version: 0xffff80ee)

@Joshua-Ashton
Copy link
Owner

Yeah that log line would be the root cause of the problem... Do you know if it's part of the map or a model that's the problem?

@khang06
Copy link
Author

khang06 commented Aug 30, 2022

Looks like it's caused by a file called bridge_railing.phy, which isn't included with the map. Not sure where it is right now, but I'll try looking.

Edit: Hmmm...the workshop page for gm_fork says it doesn't need addons, so I'm even more confused about where this file is coming from

@khang06
Copy link
Author

khang06 commented Aug 30, 2022

Okay, I found it. Not sure if you're okay with me uploading the model here, but you can find it in Half Life 2's hl2_misc_dir.vpk in models/props_wasteland.

Joshua-Ashton added a commit that referenced this issue Aug 30, 2022
These legacy style .phy files are literally just serialized compact surfaces
and nothing else, with some misc. data shoved into some dummy compartment.

Some props in shipping HL2 still use this format, as they have a .phy, even after their
.qc had the $collisionmodel removed, as they didn't get the stale .phy in the game files deleted.

Closes: #35
Joshua-Ashton added a commit that referenced this issue Aug 30, 2022
These legacy style .phy files are literally just serialized compact surfaces
and nothing else, with some misc. data shoved into some dummy compartment.

Some props in shipping HL2 still use this format, as they have a .phy, even after their
.qc had the $collisionmodel removed, as they didn't get the stale .phy in the game files deleted.

Closes: #35
@Joshua-Ashton
Copy link
Owner

Fixed by that commit, will be in the next release

@Joshua-Ashton Joshua-Ashton added this to the Version 0.11 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants