Enable .json file extension for json responses #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To automatically set the correct content-type for application/json responses, check if the response is a JsonResponse and if so, create a .json file instead of a .html file.
I didn't write a test since I didn't know where to start to be honest.
It is not perfect since the ending "json" is hardcoded but in the future, the determineFileExtension method could be extended if needed.
Also, the forget method is not the most elegant with trying to delete either a .html or a .json file. If you have a better idea on how to solve that, please let me know and I'll try to rewrite it. I've chosen this way since at least in my applications, it's always either a html or json response which would benefit the most from the caching.
Cheers!