-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove null checks and allow it to be queried #608
Conversation
Also, if you don't mind adding the |
I've ran into the same situation when checking roles assignment. I have a scoped assigned role, but when I check I will try to include an update for that. |
Hi @JosephSilber, any plans to get this merged? Thanks for taking the time! |
Whoops. I should've gotten to this way sooner, especially since you put in all that work creating the issue, the repro repo and a PR with tests! Sorry. I left you a small review. Check it out, and let's get this merged. |
Co-authored-by: Joseph Silber <contact@josephsilber.com>
Thanks man, I've made those suggested edits. No worries on the delay! |
Never mind, my local repo was out of date with this. Anyway, you were right on all of the suggestions. |
Merged. Thanks! |
Well, this broke my app, but in a good way because it turns out we had scopes set when they weren't even being used (best guess is experimentation 😅). |
…)" This reverts commit 502221b.
Fix #607. This has the expected behavior and not so eager to grant permissions when you may not want them to be granted.