Simplify with crossJoin

JosephSilber · Feb 21, 2022 · fcbb176 · fcbb176
1 parent 91b32a2
commit fcbb176
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Conductors/AssignsRoles.php b/src/Conductors/AssignsRoles.php
@@ -98,15 +98,15 @@ protected function getExistingAttachRecords($roleIds, $morphType, $authorityIds)
      */
     protected function buildAttachRecords($roleIds, $morphType, $authorityIds)
     {
-        return $roleIds->map(function ($roleId) use ($morphType, $authorityIds) {
-            return $authorityIds->map(function ($authorityId) use ($roleId, $morphType) {
+        return $roleIds
+            ->crossJoin($authorityIds)
+            ->mapSpread(function ($roleId, $authorityId) use ($morphType) {
                 return Models::scope()->getAttachAttributes() + [
                     'role_id' => $roleId,
                     'entity_id' => $authorityId,
                     'entity_type' => $morphType,
                 ];
             });
-        })->collapse();
     }
 
     /**