Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use global thanos metrics and other changes #1

Merged

Conversation

ashwanthgoli
Copy link

@ashwanthgoli ashwanthgoli commented Oct 9, 2024

What this PR does / why we need it:

  • use a global thanos metric.
  • remove ruler changes, will be added in a separate pr
  • rename configs

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli changed the title use global thanos metrics use global thanos metrics and othe changes Oct 9, 2024
Copy link
Owner

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoaoBraveCoding JoaoBraveCoding changed the title use global thanos metrics and othe changes use global thanos metrics and other changes Oct 9, 2024
@JoaoBraveCoding JoaoBraveCoding merged commit ca835ad into JoaoBraveCoding:log-4550-gcp Oct 9, 2024
5 of 6 checks passed
@JoaoBraveCoding JoaoBraveCoding deleted the thanos-global-metric branch October 9, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants