Feature 87 import resource by csv #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladoKat
requested changes
May 19, 2024
pom.xml
Outdated
| <dependency> | ||
| <groupId>com.fasterxml.jackson.dataformat</groupId> | ||
| <artifactId>jackson-dataformat-csv</artifactId> | ||
| <version>2.17.0</version> |
There was a problem hiding this comment.
I think the version can be omitted.
| return savedResources; | ||
| } | ||
|
|
||
| private void csvVerification(MultipartFile file) { |
There was a problem hiding this comment.
Method names should be verbs
Suggested change
| private void csvVerification(MultipartFile file) { | |
| private void verifyIsCsv(MultipartFile file) { |
| CsvSchema schema = CsvSchema.emptySchema().withHeader(); | ||
|
|
||
| MappingIterator<ResourceRequestDto> resourcesIterator; | ||
| List<ResourceRequestDto> resourcesDto; |
There was a problem hiding this comment.
Suggested change
| List<ResourceRequestDto> resourcesDto; | |
| List<ResourceRequestDto> resourceDtos; |
VladoKat
approved these changes
May 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.