This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Map returned Unit to void in more cases when producing framework #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olonho
reviewed
May 13, 2019
| } | ||
| ) | ||
|
|
||
| private fun ObjCExportMapper.bridgeFunctionType(kotlinType: KotlinType): TypeBridge { | ||
| val numberOfParameters = kotlinType.arguments.size - 1 |
There was a problem hiding this comment.
Better comment why -1, I guess.
Including function-typed parameters and return types
SvyatoslavScherbina
force-pushed
the
objcexport-void-blocks
branch
from
6ac3cf9
to
a0abfa7
Compare
olonho
approved these changes
May 21, 2019
This was referenced May 22, 2019
LepilkinaElena
pushed a commit
that referenced
this pull request
May 27, 2019
Including function-typed parameters and return types.
artdfel
pushed a commit
that referenced
this pull request
Jun 10, 2019
Including function-typed parameters and return types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including function-typed parameters and return types