fix!: EXPOSED-569 groupConcat uses wrong SQLite syntax & ignores DISTINCT in Oracle & SQL Server #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obabichevjb
approved these changes
Sep 27, 2024
…INCT in Oracle & SQL Server - SQLite syntax now uses correct separator syntax and allows ORDER BY clause - Oracle & SQL Server now fail early with unsupported by dialect exception if distinct = true (before it would just be ignored by SQL builder).
…INCT in Oracle & SQL Server - Fixed wrong function name in exception message - Change to use appendTo() with prefix
bog-walk
force-pushed
the
bog-walk/fix-group-concat
branch
from
704093e
to
d08b38f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
groupConcat()no longer generates wrong SQL syntax for SQLite and no longer ignores unsupported parameters for Oracle and SQL Server.Detailed description:
It was observed by a user that SQLite uses the wrong syntax for a separator in its
GROUP_CONCATfuntion. They were also attempting to use the ORDER BY clause, which Exposed prevents because the database used to not support it. ORDER BY with aggregate functions has been supported since version 3.44.0.While adjusting the tests to no longer exclude, it was confirmed that SQL Server doesn't actually support DISTINCT in the function. Exposed was ignoring this value if set to
trueand not including it in SQL, whereas the usual behavior is to fail early.Oracle was doing the same thing for DISTINCT. But it was also, for some reason, preventing
groupConcat()from being used unless an argument fororderBywas provided. ORDER BY is supposed to be optional withLISTAGGfunction.(expr, '?')syntax instead of(expr, SEPARATOR '?'). Allows arguments to be passed toorderByfor syntax(expr, '?' ORDER BY col).UnsupportedByDialectExceptionifdialectis set totrue.orderBy. ThrowsUnsupportedByDialectExceptionifdialectis set totrue.Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues
EXPOSED-569