Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EXPOSED-493 Update with join query throws if WHERE clause present #2207

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: EXPOSED-493 Update with join query throws if WHERE clause present #2207

merged 2 commits into from
Aug 20, 2024

Commits on Aug 20, 2024

  1. fix: EXPOSED-493 Update with join query throws if WHERE clause present 

    Previous refactoring of UpdateStatement.arguments() to properly order registered
arguments in an update-from-join statement did not factor in the possibility that
the join target would be a subquery or QueryAlias. If this query itself holds a WHERE
clause with arguments, the latter will not be registered when preparing the statement,
leading to the same 'parameter not filled' errors as previously.

This PR ensures any query arguments are registered just before the rest of the join
part additional arguments, at whatever point that may be for each database.

Tests for single and multiple joins, and joins with update-where, have been edited
to include joins with a subquery.
    @bog-walk
    bog-walk committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b28fe48 View commit details
    Browse the repository at this point in the history

  2. fix: EXPOSED-493 Update with join query throws if WHERE clause present 

    - Break up new tests into separate unit tests
- Fix typos in update(where) unsupported exceptions
- Rebase from main
    @bog-walk
    bog-walk committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e17ce9c View commit details
    Browse the repository at this point in the history