Write two tests that catch a possible bug with SQLite + batchInsert #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two errors show up:
1. A customly declared ID column is not set to the `id` property on DAO `new {}`
2. The ResultRow from a `batchInsert` fails to unwrap data on 2 ways:
- if you check the `id` first, it fails because it becomes 1 instead of "batman" as the test expected
- if you check `username` first, it fails later on `id` because the ResultRow caches the internal lookup, but the cache doesn't make a distinction
between the return value String and EntityID<String> - creating a ClassCastException
bystam
commented
Jun 7, 2024
| val result1 = User.batchInsert(listOf("batman")) { username -> | ||
| this[User.username] = username | ||
| }.single() | ||
| assertEquals("batman", result1[User.id].value) |
There was a problem hiding this comment.
Fails, because result1[User.id].value is 1 on SQLite
bystam
commented
Jun 7, 2024
| this[User.username] = username | ||
| }.single() | ||
| assertEquals("superman", result2[User.username]) | ||
| assertEquals("superman", result2[User.id].value) |
There was a problem hiding this comment.
Fails, because result2[User.username] caches the return value as a String, meaning result2[User.id].value produces a ClassCastException
There was a problem hiding this comment.
Arguably should be a separate PR, because this is not related to SQLite specifically - this fails on any database
There was a problem hiding this comment.
Created another https://youtrack.jetbrains.com/issue/EXPOSED-409/Custom-primary-key.-Access-to-the-primary-key-fails-with-ClassCastException issue for the second problem. It's clear why it happens, I'll try to fix it a bit later.
|
Fixed by PR #2119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack: https://youtrack.jetbrains.com/issue/EXPOSED-405/SQLite-bugs-Table-with-custom-ID-behaves-weirdly-in-DAO-and-batchInsert
Two errors show up:
1. A customly declared ID column is not set to the
idproperty on DAOnew {}2. The ResultRow from a
batchInsertfails to unwrap data on 2 ways:- if you check the
idfirst, it fails because it becomes 1 instead of "batman" as the test expected- if you check
usernamefirst, it fails later onidbecause the ResultRow caches the internal lookup, but the cache doesn't make a distinctionbetween the return value String and EntityID - creating a ClassCastException