-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #25
base: master
Are you sure you want to change the base?
Various fixes #25
Conversation
update to edition 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, mostly appears to be a cargo fmt
run and some clippy improvements, but also refactors PrimarySource
from an enum
to a struct with associated consts rather than variants.
pub const OPPS: PrimarySource = PrimarySource(code_to_u32!(b"OPPS")); | ||
pub const FREE: PrimarySource = PrimarySource(code_to_u32!(b"FREE")); | ||
pub const INIT: PrimarySource = PrimarySource(code_to_u32!(b"INIT")); | ||
pub const NULL: PrimarySource = PrimarySource(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thought I'd mention you can also use pub const NULL: Self = Self(0);
, etc which can make future refactoring a little easier, but doesn't really matter.
No description provided.