Merge pull request #13 from Jeckel-Lab/bugfix/several-bug-with-typing

Remove useless toScalar methods
Jeckel-Lab · Dec 18, 2020 · dbb3eee · dbb3eee
2 parents 0548edb + 641b83b
commit dbb3eee
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/src/Domain/Identity/Identity.php b/src/Domain/Identity/Identity.php
@@ -20,16 +20,11 @@ interface Identity extends Equality
 {
     /**
      * IdAbstract constructor.
-     * @param T|null $id
+     * @param T $id
      * @throws InvalidIdException
      */
     public function __construct($id);
 
-    /**
-     * @return string
-     */
-    public function toScalar(): string;
-
     /**
      * @return string
      */

diff --git a/src/Domain/ValueObject/ValueObject.php b/src/Domain/ValueObject/ValueObject.php
@@ -10,16 +10,9 @@
 /**
  * Interface ValueObject
  * @psalm-immutable
- * @template T
  */
 interface ValueObject
 {
-    /**
-     * @psalm-return T
-     * @return T
-     */
-    public function toScalar();
-
     /**
      * @return string
      */