Fix objectives tests #348
Merged
Fix objectives tests #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set 64 bit precision in objectives tests due to change in JaxGaussianProcesses#347 causing tests to fail when run in isolation.
thomaspinder
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set 64 bit precision in objectives tests due to change in #347 causing tests to fail when run in isolation.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failurebefore committing.Description
Objectives tests were failing when run in isolation due to #347. However, when all tests where run together they would pass (presumably due to 64 bit precision being set by an earlier set of tests). Therefore, 64 bit precision has been added to the objectives tests so that they can be run successfully in isolation.
Issue Number: N/A