Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failure
before committing.Description
Have added a warning using the
warnings
package that informs when X or y isn't of dtype float64 (if the warnings package isn't appropriate then please let me know, it's a new import withindataset.py
). This is called immediately after checking the dataset shape:I've added a test for the warning generation, but to do so I had to enable the higher precision within
test_dataset.py
(config.update("jax_enable_x64", True)
) . I hope this solution is alright. Thanks!Issue Number: #342