Enhanced to support targeting inner elements #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to add custom attributes to specific inner child elements within a module's, column's, or row's wrapper. Changes Made: Form: - Added a new field target in the custom attributes form to specify the CSS selector for the target inner element. Custom Attribute Handling: - Modified the filterAttributes function to handle attributes with and without target selectors. - Attributes with target selectors are stored in the data-custom-attributes attribute as a JSON string. - Attributes without target selectors are added directly to the wrapper element as before JavaScript: -Enqueued a script using the DOMContentLoaded event to process custom attributes as soon as the DOM is fully loaded. - Reads the data-custom-attributes attribute, if present. - Parses the JSON string to get the list of custom attributes. - Applies the custom attributes to the specified target elements within the wrapper. - Removes the data-custom-attributes attribute from the wrapper element after processing.
JasonTheAdams
approved these changes
Jul 17, 2024
|
Great! I have tested it on my own site and works well. I will have someone else test to confirm it doesn't "only work on my setup" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to add custom attributes to specific inner child elements within a module's, column's, or row's wrapper.
Changes Made:
Form:
Custom Attribute Handling:
JavaScript: