Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[SET-OPERATION] supersetof, subsetof and disjointof filter for filter_compare"" #1005

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ypkang
Copy link
Contributor

@ypkang ypkang commented Mar 13, 2023

Reverts #1003

…ilter for filter_compare""

This reverts commit 226add9.
@marsninja
Copy link
Contributor

I'd be happy to merge this pr if we change the normanclature to subs, sups, and mexs instead of subsetof, supersetof, and disjointof

Also I'd have these implemenations accept both lists and dictionaries (in the case of dictionaries the operator should work on [k, v] equality)

bonus points for updating +, -, and * to support lists and dictionaries in a set theory type way where + is union, - is difference, and * is intersection (with dups allowed in all cases), of course the comparison ops above should apply on set casts of the lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants