#29 Don't flag constructors when this is not present #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the node version needs to be bumped? https://github.com/JamieMason/eslint-plugin-prefer-arrow-functions/blob/main/.nvmrc I thought this was fixed... 😄 |
|
Hi @JamieMason , could this be looked at please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (What)
Fixes #29.
Constructors like this:
don't have
this, so they get incorrectly flagged by the plugin. We should be sure to exclude all constructors from this rule.Justification (Why)
Because constructors cannot be arrow functions.
How Can This Be Tested?
See tests, you can revert the fix to demonstrate that this change works.