Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix theme switching exception #8939

Merged
merged 6 commits into from
Jul 3, 2022
Merged

Fix theme switching exception #8939

merged 6 commits into from
Jul 3, 2022

Commits on Jun 30, 2022

  1. Remove installCss(dialogScene) from dialogs because JavaFX already ha… 

    …ndle that

- If we update dialog stylesheet ourselves than we're breaking the binding made by JavaFX and thus unexpected behaviours may/will happen
    @HoussemNasri
    HoussemNasri committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    534fefe View commit details
    Browse the repository at this point in the history

  2. Use only main window scene in ThemeManager

    @HoussemNasri
    HoussemNasri committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    34f0465 View commit details
    Browse the repository at this point in the history

  3. Checkstyle

    @HoussemNasri
    HoussemNasri committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    8d46f6d View commit details
    Browse the repository at this point in the history

  4. Refactor code

    @HoussemNasri
    HoussemNasri committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    ab9cb00 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.md

    @HoussemNasri
    HoussemNasri committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    699238a View commit details
    Browse the repository at this point in the history

  6. Use Optional.ofNullable for returning the main window scene

    @HoussemNasri
    HoussemNasri committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    dca4d57 View commit details
    Browse the repository at this point in the history