Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open office refactor finalization (formerly OObranch J cleanup) #7795

Merged
merged 127 commits into from
Mar 11, 2022

Commits on May 27, 2021

  1. Configuration menu
    Copy the full SHA
    a50cc79 View commit details
    Browse the repository at this point in the history
  2. correction: import order

    antalk2 committed May 27, 2021
    Configuration menu
    Copy the full SHA
    d93bd56 View commit details
    Browse the repository at this point in the history
  3. add general utilities

    antalk2 committed May 27, 2021
    Configuration menu
    Copy the full SHA
    c9b72e9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    381a549 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Configuration menu
    Copy the full SHA
    f94c1f6 View commit details
    Browse the repository at this point in the history
  2. add ootext

    antalk2 committed May 28, 2021
    Configuration menu
    Copy the full SHA
    f9a8176 View commit details
    Browse the repository at this point in the history
  3. add rangesort

    antalk2 committed May 28, 2021
    Configuration menu
    Copy the full SHA
    6d013f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Configuration menu
    Copy the full SHA
    0434579 View commit details
    Browse the repository at this point in the history
  2. add Tuple3

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    3c45a8a View commit details
    Browse the repository at this point in the history
  3. add ootext

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    32f7a43 View commit details
    Browse the repository at this point in the history
  4. add rangesort

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    6bae6b4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    314902c View commit details
    Browse the repository at this point in the history
  6. rangeSort update

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    dfe18bc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c9f4e57 View commit details
    Browse the repository at this point in the history
  8. cleanup

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    6e4c7c2 View commit details
    Browse the repository at this point in the history
  9. style additions

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    9388b2a View commit details
    Browse the repository at this point in the history
  10. add backend

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    d2a53c7 View commit details
    Browse the repository at this point in the history
  11. add frontend

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    0fed618 View commit details
    Browse the repository at this point in the history
  12. add actions

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    3632d00 View commit details
    Browse the repository at this point in the history
  13. add gui stuff

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    fc534c1 View commit details
    Browse the repository at this point in the history
  14. integrate

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    b660d32 View commit details
    Browse the repository at this point in the history
  15. cleanup

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    e12fdb7 View commit details
    Browse the repository at this point in the history
  16. checkstyle on tests

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    88cab9c View commit details
    Browse the repository at this point in the history
  17. add missing message

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    b7aaf2a View commit details
    Browse the repository at this point in the history
  18. add backend

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    0fa9a4c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    946242f View commit details
    Browse the repository at this point in the history
  20. add frontend

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    a5b7a05 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    765f570 View commit details
    Browse the repository at this point in the history
  22. add actions

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    c50c458 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    da39254 View commit details
    Browse the repository at this point in the history
  24. add gui stuff

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    00527f4 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    889f3fd View commit details
    Browse the repository at this point in the history
  26. integrate

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    90078c7 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    8deb22b View commit details
    Browse the repository at this point in the history
  28. cleanup

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    3e001c5 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    577de74 View commit details
    Browse the repository at this point in the history
  30. remove duplicate

    antalk2 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    3dd6d09 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Configuration menu
    Copy the full SHA
    e2ddc35 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e236a81 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    61fa941 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6a3d19e View commit details
    Browse the repository at this point in the history
  5. not using RangeSet

    antalk2 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    41f1311 View commit details
    Browse the repository at this point in the history
  6. not using RangeSet

    antalk2 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    0f398bd View commit details
    Browse the repository at this point in the history
  7. not using RangeSet

    antalk2 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    7e6667d View commit details
    Browse the repository at this point in the history
  8. merged

    antalk2 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    00fa0ad View commit details
    Browse the repository at this point in the history
  9. cleanup

    antalk2 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    361d3ef View commit details
    Browse the repository at this point in the history
  10. remove duplicate

    antalk2 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    614b7f7 View commit details
    Browse the repository at this point in the history
  11. toString

    antalk2 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    292f351 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1ad1d1c View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. add docs/openoffice

    antalk2 committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    956992e View commit details
    Browse the repository at this point in the history
  2. markdown-lint

    antalk2 committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    982b27a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2021

  1. use StringUtil.isNullOrEmpty

    antalk2 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    ad194e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff8517b View commit details
    Browse the repository at this point in the history
  3. in response to review

    JabRef#7788 (review)
    
    - more use of StringUtil.isNullOrEmpty
    - private final XTextRangeCompare cmp;
    - List<V> partition = partitions.computeIfAbsent(partitionKey, _key -> new ArrayList<>());
    - visualSort does not throw WrappedTargetException, NoDocumentException
    - set renamed to comparableMarks
    antalk2 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    7ec1cc2 View commit details
    Browse the repository at this point in the history
  4. use {@code }, PMD suggestions

    antalk2 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    bf94bf5 View commit details
    Browse the repository at this point in the history
  5. use StringUtil.isNullOrEmpty

    antalk2 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    b829590 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    28a019a View commit details
    Browse the repository at this point in the history
  7. in response to review

    JabRef#7788 (review)
    
    - more use of StringUtil.isNullOrEmpty
    - private final XTextRangeCompare cmp;
    - List<V> partition = partitions.computeIfAbsent(partitionKey, _key -> new ArrayList<>());
    - visualSort does not throw WrappedTargetException, NoDocumentException
    - set renamed to comparableMarks
    antalk2 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    8c7ad3f View commit details
    Browse the repository at this point in the history
  8. use {@code }, PMD suggestions

    antalk2 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    66d48a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Configuration menu
    Copy the full SHA
    cfaa5f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8bae01 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6d7b8a1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cb0ca45 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a60211b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    da0ae0a View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. Configuration menu
    Copy the full SHA
    f224dc0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac51403 View commit details
    Browse the repository at this point in the history
  3. drop normalizePageInfos, use 'preferred' and 'fallback' in getAuthorL…

    …astSeparatorInTextWithFallBack
    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    e0151eb View commit details
    Browse the repository at this point in the history
  4. checkstyle

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    d7bf2fb View commit details
    Browse the repository at this point in the history
  5. use putIfAbsent

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    dd6d1c6 View commit details
    Browse the repository at this point in the history
  6. use "{}" with LOGGER

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    7cb166c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e832a10 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4ba4e66 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    46f7231 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    55686e3 View commit details
    Browse the repository at this point in the history
  11. OOBibStyle

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    c1491e9 View commit details
    Browse the repository at this point in the history
  12. checkstyle

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    e0783df View commit details
    Browse the repository at this point in the history
  13. use putIfAbsent

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    09748e3 View commit details
    Browse the repository at this point in the history
  14. use "{}" with LOGGER

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    e0fb50d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1268e60 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6107f4b View commit details
    Browse the repository at this point in the history
  17. drop import StringUtil

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    a87d6b8 View commit details
    Browse the repository at this point in the history
  18. drop import ArrayList

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    6b5055a View commit details
    Browse the repository at this point in the history
  19. more use of "{}" in LOGGER

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    8a29981 View commit details
    Browse the repository at this point in the history
  20. more use of "{}" in LOGGER

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    2725b64 View commit details
    Browse the repository at this point in the history
  21. more use of "{}" in LOGGER

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    c7cb442 View commit details
    Browse the repository at this point in the history
  22. more use of "{}" in LOGGER

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    d86eadf View commit details
    Browse the repository at this point in the history
  23. more use of "{}" in LOGGER

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    fa2b24a View commit details
    Browse the repository at this point in the history
  24. more use of "{}" in LOGGER

    antalk2 committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    a83a3af View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. Citation.lookup: use streams

    antalk2 committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    2224e68 View commit details
    Browse the repository at this point in the history
  2. Citation.lookup: use streams

    antalk2 committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    220dcc4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eff50ad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    69c4d6b View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. removed catch RuntimeException around UnoCursor.getViewCursor

    Apparently cannot throw here.
    NoDocumentException is caught elsewhere, before we get here.
    com.sun.star.uno.RuntimeException is caught below, for cursor.getStart();
    antalk2 committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    c093d9d View commit details
    Browse the repository at this point in the history
  2. removed catch RuntimeException around UnoCursor.getViewCursor

    Apparently cannot throw here.
    NoDocumentException is caught elsewhere, before we get here.
    com.sun.star.uno.RuntimeException is caught below, for cursor.getStart();
    antalk2 committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    d579c80 View commit details
    Browse the repository at this point in the history
  3. drop unused message

    antalk2 committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    1d9163d View commit details
    Browse the repository at this point in the history
  4. drop unused message

    antalk2 committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    71bb543 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dc590db View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8e4b2e5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    94cb611 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    26ae70a View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. What is 52 in Backend52

    antalk2 committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    ae22fec View commit details
    Browse the repository at this point in the history
  2. What is 52 in Backend52

    antalk2 committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    26fa1b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. apply 2021-08-20-a/oobranch-E-update.patch

    Brings oobranch-E up to
    89b0968 @ origin/improve-reversibility-rebased-03 Merge remote-tracking branch 'upstream/main' into improve-reversibility-rebased-03
    antalk2 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    f373daf View commit details
    Browse the repository at this point in the history
  2. apply 2021-08-20-a/oobranch-E-update.patch

    Brings oobranch-E up to
    89b0968 @ origin/improve-reversibility-rebased-03 Merge remote-tracking branch 'upstream/main' into improve-reversibility-rebased-03
    antalk2 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    f33bafa View commit details
    Browse the repository at this point in the history
  3. sync to improve-reversibility-rebased-03 cb13256

    commit cb13256 (HEAD -> improve-reversibility-rebased-03, origin/improve-reversibility-rebased-03)
    Author: Antal K <antalk2@gmail.com>
    Date:   Fri Aug 20 11:39:39 2021 +0200
    
        align dots
    antalk2 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    1fcb009 View commit details
    Browse the repository at this point in the history
  4. sync to improve-reversibility-rebased-03 cb13256

    commit cb13256 (HEAD -> improve-reversibility-rebased-03, origin/improve-reversibility-rebased-03)
    Author: Antal K <antalk2@gmail.com>
    Date:   Fri Aug 20 11:39:39 2021 +0200
    
        align dots
    antalk2 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    0cea6ae View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Configuration menu
    Copy the full SHA
    abd8880 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a76ae67 View commit details
    Browse the repository at this point in the history
  3. longer name

    antalk2 committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    ec253d0 View commit details
    Browse the repository at this point in the history
  4. follow some PMD suggestions

    antalk2 committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    1f6700c View commit details
    Browse the repository at this point in the history
  5. follow some PMD suggestions

    antalk2 committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    f782981 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Configuration menu
    Copy the full SHA
    70e0ca0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    074d662 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Configuration menu
    Copy the full SHA
    3fabcc2 View commit details
    Browse the repository at this point in the history
  2. apply suggested changes

    antalk2 committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    fd8584b View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Merge remote-tracking branch 'upstream/main' into oobranch-H

    # Conflicts:
    #	src/main/resources/l10n/JabRef_en.properties
    calixtus committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    c1a6d59 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Merge remote-tracking branch 'upstream/main' into oobranch-J

    # Conflicts:
    #	src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java
    #	src/main/java/org/jabref/logic/openoffice/action/EditInsert.java
    #	src/main/java/org/jabref/logic/openoffice/action/EditMerge.java
    #	src/main/java/org/jabref/logic/openoffice/action/EditSeparate.java
    #	src/main/java/org/jabref/logic/openoffice/action/ExportCited.java
    #	src/main/java/org/jabref/logic/openoffice/action/Update.java
    #	src/main/resources/l10n/JabRef_en.properties
    calixtus committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    b275709 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'oobranch-H' into oobranch-J

    # Conflicts:
    #	src/main/java/org/jabref/logic/openoffice/action/Update.java
    #	src/main/java/org/jabref/logic/openoffice/style/OOBibStyle.java
    #	src/main/resources/l10n/JabRef_en.properties
    #	src/test/java/org/jabref/logic/openoffice/style/OOBibStyleTest.java
    #	src/test/java/org/jabref/logic/openoffice/style/OOBibStyleTestHelper.java
    calixtus committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    79c4f0d View commit details
    Browse the repository at this point in the history
  3. fixed merge errors

    calixtus committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    059e1d9 View commit details
    Browse the repository at this point in the history
  4. reformatted

    calixtus committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    1e37728 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. Configuration menu
    Copy the full SHA
    7d391d3 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'antalk2/oobranch-J' into oobranch-J

    # Conflicts:
    #	src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java
    calixtus committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    003db88 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    efb0f1c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Applied some ide suggestions, reworded some variables, reworded-remov…

    …ed-reformatted some comments
    calixtus committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    f4f5b57 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Changed File to Path

    Co-authored-by: Christoph <siedlerkiller@gmail.com>
    calixtus and Siedlerchr committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    c881e09 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/main' into oobranch-J

    # Conflicts:
    #	src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java
    #	src/main/java/org/jabref/logic/openoffice/style/OOBibStyle.java
    #	src/main/java/org/jabref/logic/openoffice/style/StyleLoader.java
    #	src/test/java/org/jabref/logic/openoffice/style/OOBibStyleTest.java
    calixtus committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    303e7a6 View commit details
    Browse the repository at this point in the history