Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some fetcher test #7225

Merged
merged 6 commits into from
Dec 22, 2020
Merged

Fix some fetcher test #7225

merged 6 commits into from
Dec 22, 2020

Conversation

DominikVoigt
Copy link
Contributor

This PR fixes some of the failing fetcher tests specified in #6369.
Namely:

  • Jstor: Result differs
  • CiteSeer: Result differs
  • TitleFetcher: Change format
  • Disable CompositeFetcherTest on CI
  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@DominikVoigt
Disable composite fetcher test
4265e2b 
Signed-off-by: Dominik Voigt <Dominik.ingo.voigt@gmail.com>
@DominikVoigt
Fix citeseerx test
0342b7b 
Enable doi search for complex search queries

Signed-off-by: Dominik Voigt <Dominik.ingo.voigt@gmail.com>
@DominikVoigt
Fix JSTOR searchById
81a4ac8 
Signed-off-by: Dominik Voigt <Dominik.ingo.voigt@gmail.com>
@DominikVoigt
Fix TitleFetcher
b21f412 
Signed-off-by: Dominik Voigt <Dominik.ingo.voigt@gmail.com>
@DominikVoigt DominikVoigt changed the title Disable composite fetcher test Fix fetcher test Dec 22, 2020
@DominikVoigt DominikVoigt changed the title Fix fetcher test Fix some fetcher test Dec 22, 2020
Siedlerchr
Siedlerchr approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor annoation change

src/test/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcherTest.java Outdated Show resolved Hide resolved
@calixtus
Copy link
Member

/home/runner/work/jabref/jabref/src/test/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcherTest.java:32: error: cannot find symbol
@DisabledOnCIServer("Produces to many requests on CI")
^
symbol: class DisabledOnCIServer

@DominikVoigt
Add missing import
48a16af 
Signed-off-by: Dominik Voigt <Dominik.ingo.voigt@gmail.com>
@DominikVoigt
Copy link
Contributor Author

Fixed! 😄

@Siedlerchr Siedlerchr merged commit d83ef74 into master Dec 22, 2020
@Siedlerchr Siedlerchr deleted the fix/failing-fetcher-tests branch December 22, 2020 10:16
Siedlerchr added a commit that referenced this pull request Dec 23, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into importerbackgroun…
1d25e30 
…dtask

* upstream/master:
  fxdocs changed their URL (#7230)
  New Crowdin updates (#7227)
  Fix some fetcher test (#7225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DominikVoigt @calixtus @Siedlerchr