Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "online" prefix in the expected file URLs to fix Springer fetcher tests #6968

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Remove "online" prefix in the expected file URLs to fix Springer fetcher tests #6968

merged 1 commit into from
Oct 1, 2020

Conversation

Toromtomtom
Copy link
Contributor

This addresses two of the errors in the fetcher tests as run by the CI (see #6369). Examples for the failures are here and here.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes that was recently changed. Thanks for fixing this

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks, overlooked them. Thank you very much.

@calixtus calixtus merged commit b84ce69 into JabRef:master Oct 1, 2020
@Toromtomtom Toromtomtom deleted the fix-springer-fetcher-tests branch October 2, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants