Rename menus citation style in preview style #6899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlep
changed the title
|
We have to differ between our own custom html preview style and the CSL styles. I think wee need to be careful here. I've tagged this for discussion so we developers can talk about that in our next dev call |
|
Sure! |
|
DevCall:
|
tobiasdiez
added
the
status: changes required
|
@koppor Sorry, but I do not understand your point 2. |
|
I rewrote the second point now:
Now, the text should also match the screenshots, doesn't it? |
|
Got it. |
|
Took the liberty to help you a little bit @mlep with the renaming of the preview style. Hope you don't mind. |
calixtus
added
status: ready-for-review
koppor
approved these changes
Sep 26, 2020
stefan-kolb
approved these changes
Sep 26, 2020
Siedlerchr
added a commit
that referenced
this pull request
Sep 26, 2020
* upstream/master: (55 commits) Rename menus citation style in preview style (#6899) Fix for some Unicode characters in citation keys (#6938) Add missing authors Fix a fetcher test for the ShortDOIService (#6945) Fixes Shared Database: Changes filtering in CoarseChangeFilter to attribute property (#6868) Changed default value of "search and store files relative to bibtex file" to true (#6928) Replace comment by just a failure (#6943) Fix: in entry types editor selected field is not removed after first click (#6941) Fix remove actions for entry types in the editor (#6933) Always use Java 15 (#6929) Update DevDocs: workaround for issues with local openjfx maven libraries (#6931) Fixes bugs in the `regex` cite key pattern modifier (#6893) Add missing author Readability for citation key patterns (#6706) Add new author Reset to master and add default case to switch (#6847) Bump mockito-core from 3.5.10 to 3.5.11 (#6924) Bump byte-buddy-parent from 1.10.14 to 1.10.15 (#6923) Bump org.beryx.jlink from 2.21.4 to 2.22.0 (#6925) Bump xmpbox from 2.0.20 to 2.0.21 (#6926) ... # Conflicts: # src/main/java/org/jabref/logic/util/DelayTaskThrottler.java
|
@calixtus Thank you for finishing the work (I was not able to do it by myself) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JabRef 5.2, an entry preview is displayed in the entry editor.
The preview style can be configured in Options -> Preference -> Entry preview.
The menu to switch between preview styles are View -> Next citation style and View -> Previous citation style.
When a menu is activated, it display an information message mentioning "Preview".
The issue is that the name of these two menus are confusing, because in fact, they are not about citation style but about preview style.
This PR renames the menus by changing the word citation into preview:
.