-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline new library command #6773
Merged
Merged
Changes from 18 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7629ee2
Squashed 'src/main/resources/csl-styles/' changes from 586e0b8408..c5…
5f72ad3
Merge commit '7629ee29c5b60711da5d1c64f8c2c8e146e90d6f'
52a6426
Squashed 'src/main/resources/csl-styles/' changes from c5f14e2c4d..71…
f678e52
Merge commit '52a64264feb20ea3506f7f11e70fcf24ec768682'
8887205
Squashed 'src/main/resources/csl-styles/' changes from 716f63557c..a9…
47bbd31
Merge commit '88872055561d37157537aece4b5d9fa859a138e9'
230305f
Squashed 'src/main/resources/csl-styles/' changes from a995c63a0a..bf…
8cdb629
Merge commit '230305ff8acf22110d88d441b552e634f17e0a6e'
7342055
Squashed 'src/main/resources/csl-styles/' changes from bf698acec7..7c…
5fd80c2
Merge commit '73420559d42065980d8dbbe6be6825f5a2e3ab18'
877a0c4
Squashed 'src/main/resources/csl-styles/' changes from 7cab2f7d8a..82…
1541cd1
Merge commit '877a0c4daf0117d4f910a5c5b679ad824c63bda9'
7ff4633
Squashed 'src/main/resources/csl-styles/' changes from 827b986621..eb…
8f1de8e
Merge commit '7ff46331ad541719aad203eb33d44e21db721554' into master
1bc3681
Merge remote-tracking branch 'origin/master' into master
calixtus 98bfe5a
Merge remote-tracking branch 'upstream/master' into master
calixtus f482de6
Merged new library actions
calixtus 8e41efd
l10n
calixtus d37a3dd
Removed unused constructor
calixtus 262d29d
Fixed checkstyle failed check
calixtus 3e27db6
Fixed one more checkstyle issue
calixtus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this constructor used somewhere? (I couldn't find it in the changelog, but maybe I'm missing something).
If not then, the
mode
andshouldUseDefaultMode
variables can be deleted as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I just thought I could leave it in, if someone decides to create a specific type of a library. Just a thought...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of unused/dead code...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh... 😉