Add JavaFX installation notes #6679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo and also add javafx to jdk14
|
I have only the jdk installed (via zulu distro) and no problem with JavaFX. Thus I wouldn't phrase it that it is really needed (I have no problem with recommend LibericaJDK). (Also the issue linked wasn't about JavaFX - the problem was probably that the resource folder wasn't specified correctly and thus the language files were not found.) |
Siedlerchr
approved these changes
Jul 12, 2020
Siedlerchr
added a commit
that referenced
this pull request
Jul 13, 2020
michaellass
added a commit
to michaellass/AUR
that referenced
this pull request
Dec 26, 2020
Notes: * Remove patch for jabrefHost.py which is now included upstream. * Update start script. * Update StartupWMClass in desktop file. * Bump required JDK version to 14. Officially, version 15 is required but 14 still seems to work. I cannot test 13 anymore and there is only a single JDK 13 package in AUR, so let's drop support for that. * In contrast to the devdocs, javafx is not required to build jabref when using gradle. See JabRef/jabref#6679.
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Jul 28, 2022
Notes: * Remove patch for jabrefHost.py which is now included upstream. * Update start script. * Update StartupWMClass in desktop file. * Bump required JDK version to 14. Officially, version 15 is required but 14 still seems to work. I cannot test 13 anymore and there is only a single JDK 13 package in AUR, so let's drop support for that. * In contrast to the devdocs, javafx is not required to build jabref when using gradle. See JabRef/jabref#6679.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6678.
Up to now, we claimed that JavaFX magically works. One developer now showed up and said that plain OpenJDK does not work. On my machine, I always had to use LibericaJDK.
This PR makes that explicit.
Note that this change is only needed if developers use IntelliJ's internal build system. When executing JabRef using gradle, the binaries from maven central are used.
Let my quote https://openjfx.io/openjfx-docs/:
Since we claim that using the internal build system, we should also make the usage of it smooth.
Alternatively, we could keep the JDK installation part as is and move the advanced installation stuff to the IntelliJ part. IMHO, this is more confusing than keeping the JDK setup in one place in the howto.