Fix the bug #6421 #6438
Fix the bug #6421 #6438
Conversation
There was a problem hiding this comment.
Thank you very much for your fix. Codewise it looks good to me and it should now work as expected.
I just thought if there is some other way to forward the delete key event to the TextInputControl instead of handling it 'manually' here. Could you please just take a quick look? If not, it's ok too. Then we'll merge this.
I was wondering that, too. Since the key delete serves two purposes (forward delete and delete a file or an entry), I think the idea to distinguish whether that key is hit in the text window or not is good enough. |
|
Ok, thanks. I'll merge then. We hope you liked working on JabRef. As you can see, there is plenty of work with this application still to do. We are a community of open source enthusiasts working on JabRef in our free time and are always happy to welcome new contributors here. If you like, you can choose another issue to work on ('Good first issues' are easy tasks to dig a little bit into the codebase or take same larger issues, if you have some experience in Java programming). Our developer documentation ( https://devdocs.jabref.org/ ) provide some insight into the codebase and we mainly use our gitter chat to discuss problems. |
|
Oh sorry, I was a little bit too quick. Our policy is that we always wait for two approvals of core developers before merging into the master branch. So as soon another developer agrees, it's good to go. |
…ptyLib * upstream/master: (23 commits) Make wrap fields also visible in entry editor (#6315) Add launcher to fix extension import in snap (#6439) add concise message when SaveException happen (#6444) Squashed 'src/main/resources/csl-locales/' changes from 79845b087b..cbb45961b8 Squashed 'src/main/resources/csl-styles/' changes from 906cd6d..270cd32 Addition to the early pull #6438 (#6441) Fix the bug #6421 (#6438) Cleanup dead code (#6436) Fixed entry duplication on file download (#6437) Add workaround for buildSrc issue (#6433) Remove dash from illegal characters. (#6300) Docs: For developers: New architectural decision added to list (#6397) Added a download checkbox to the import dialog (#6381) Bump jaxb-xjc from 2.3.2 to 2.3.3 (#6410) Bump flexmark-ext-gfm-strikethrough from 0.61.20 to 0.61.24 (#6413) Bump byte-buddy-parent from 1.10.9 to 1.10.10 (#6408) Bump flexmark-ext-gfm-tasklist from 0.61.20 to 0.61.24 (#6412) Bump org.beryx.jlink from 2.17.8 to 2.18.0 (#6411) Bump tika-core from 1.24 to 1.24.1 (#6409) Bump flexmark from 0.61.20 to 0.61.24 (#6416) ...
* upstream/master: Addition to the early pull #6438 (#6441) Fix the bug #6421 (#6438) Cleanup dead code (#6436) Fixed entry duplication on file download (#6437) Add workaround for buildSrc issue (#6433) Remove dash from illegal characters. (#6300) Docs: For developers: New architectural decision added to list (#6397)
ca943b70d7 Fix malformed XML in raptor-journal.csl (#6455) 2fad8d1104 Update knee-surgery-sports-traumatology-arthroscopy.csl (#6441) b4422b77b7 Update guide-des-citations-references-et-abreviations-juridiques.csl (#6450) cfe85da320 Create raptor-journal.csl (#6451) afbb963346 Create arkivoc.csl (#6134) 2f21ceb7b4 correct name disambiguation rules (#6442) 5b2191f38b Update bibliothek-forschung-und-praxis.csl (#6437) aaea3097d1 Update sodertorns-hogskola-oxford.csl (#6439) e4fbc605f8 Update universite-du-quebec-a-montreal.csl (#6438) 3653118f17 Small Fix to Bio-Protocol git-subtree-dir: buildres/csl/csl-styles git-subtree-split: ca943b70d73bd4c57c0b1266ee7c54907b8f9d4f
In the text field, an edit action DELETE_ENTRY should do forward delete rather than do anything to the entry.
Fixes #6421