Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting custom entry fields that contain numerical values #6426

Merged
merged 9 commits into from
May 8, 2020
Merged

Sorting custom entry fields that contain numerical values #6426

merged 9 commits into from
May 8, 2020

Commits on May 5, 2020

  1. Add new Comparator class 

    Add a comparator for numeric cases in order to sort custom entry fields that contain numerical values
    @dimitra-karadima
    dimitra-karadima committed May 5, 2020
    Configuration menu
    Copy the full SHA
    dd44e42 View commit details
    Browse the repository at this point in the history

  2. Change Comparator class 

    Change in order for the Comparator class to wrap String and not Optional<SpecialFieldValueViewModel>
    @dimitra-karadima
    dimitra-karadima committed May 5, 2020
    Configuration menu
    Copy the full SHA
    7d0d9ff View commit details
    Browse the repository at this point in the history

  3. Merge master into branch fix-for-issue-6349

    @dimitra-karadima
    dimitra-karadima committed May 5, 2020
    Configuration menu
    Copy the full SHA
    ce3cc93 View commit details
    Browse the repository at this point in the history

  4. Add comparison for numeric values in custom entries

    @MootezSaaD
    MootezSaaD committed May 5, 2020
    Configuration menu
    Copy the full SHA
    7eaf7d2 View commit details
    Browse the repository at this point in the history

  5. Fix issues related to NPE in the comparator

    @MootezSaaD
    MootezSaaD committed May 5, 2020
    Configuration menu
    Copy the full SHA
    28fe8e3 View commit details
    Browse the repository at this point in the history

  6. Update CHANGELOG.md 

    Add the fix we implement in the appropriate section.
    @dimitra-karadima
    dimitra-karadima committed May 5, 2020
    Configuration menu
    Copy the full SHA
    3b07d48 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Add Unit Test for NumericFieldComparator 

    Check every possible input that the class might compare
    @dimitra-karadima
    dimitra-karadima committed May 6, 2020
    Configuration menu
    Copy the full SHA
    d368555 View commit details
    Browse the repository at this point in the history

  2. Fix CheckStyle styling

    @MootezSaaD
    MootezSaaD committed May 6, 2020
    Configuration menu
    Copy the full SHA
    bd64f89 View commit details
    Browse the repository at this point in the history

  3. Additional fix for CheckSyle

    @MootezSaaD
    MootezSaaD committed May 6, 2020
    Configuration menu
    Copy the full SHA
    914bac0 View commit details
    Browse the repository at this point in the history