'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option #6330

HussainArif12 · 2020-04-20T11:28:00Z

Fixes : #6307
Name area on focus instead of button whenever user clicks on 'Add subgroup' option

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

I have addressed the changes.
Also can you tell me how do we amend commits on git?
Thank you

…es 'Add subgroup'

calixtus

Some whitespaces are still wrong.

I'm not a git expert myself, but you should be able to revert commits in git, so it should be enough to open just one PR and push your changes all on on. Even if that means, that you are not undoing a commit, but instead push a new commit, that undoes the changes of a previous one.

calixtus · 2020-04-20T12:25:02Z

CHANGELOG.md

@@ -246,6 +246,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We added a 'LaTeX citations' tab to the entry editor, to search for citations to the active entry in the LaTeX file directory. It can be disabled in the preferences dialog.
 - We added an option in preferences to allow for integers in field "edition" when running database in bibtex mode. [#4680](https://github.com/JabRef/jabref/issues/4680)
 - We added the ability to use negation in export filter layouts. [#5138](https://github.com/JabRef/jabref/pull/5138)
+-Focus on Name Area instead of 'OK' button whenever user presses 'Add subgroup'


Missing whitespace

calixtus · 2020-04-20T12:25:50Z

src/main/java/org/jabref/gui/groups/GroupDialogView.java

@@ -97,7 +97,7 @@ public void initialize() {
        hierarchyText.put(GroupHierarchyType.INDEPENDENT, Localization.lang("Independent"));
        hierarchyToolTip.put(GroupHierarchyType.INDEPENDENT, Localization.lang("Independent group: When selected, view only this group's entries"));

-        nameField.textProperty().bindBidirectional(viewModel.nameProperty());
+         nameField.textProperty().bindBidirectional(viewModel.nameProperty());


Indent is off again

calixtus · 2020-04-20T12:26:09Z

src/main/java/org/jabref/gui/groups/GroupDialogView.java

@@ -131,7 +131,7 @@ public void initialize() {
        autoGroupPersonsField.textProperty().bindBidirectional(viewModel.autoGroupPersonsFieldProperty());

        texGroupFilePath.textProperty().bindBidirectional(viewModel.texGroupFilePathProperty());
-
+        


Whitespaces are superflous

Siedlerchr · 2020-04-20T12:46:57Z

I always use the simple git gui. There is a button amend last commit. But if you have pushed that commit already, you need to do a force push then. Otherwise just do a new commit with the changes. In the end we squash them on merge, so they will be all one commit.

calixtus

looks good to me 👍

Siedlerchr · 2020-04-20T14:05:37Z

CHANGELOG.md

@@ -246,6 +246,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We added a 'LaTeX citations' tab to the entry editor, to search for citations to the active entry in the LaTeX file directory. It can be disabled in the preferences dialog.
 - We added an option in preferences to allow for integers in field "edition" when running database in bibtex mode. [#4680](https://github.com/JabRef/jabref/issues/4680)
 - We added the ability to use negation in export filter layouts. [#5138](https://github.com/JabRef/jabref/pull/5138)
+- Focus on Name Area instead of 'OK' button whenever user presses 'Add subgroup'


Please also add a link to the issue like in the other lines

HussainArif12 · 2020-04-21T05:27:59Z

Changelog.md is now fixed in new commit

Siedlerchr · 2020-04-21T06:55:41Z

Thank you very much for your contribution! 👍

@ayaankazerouni

* upstream/master: Update label names Squashed 'src/main/resources/csl-locales/' changes from d0ee4d13c9..79845b087b Squashed 'src/main/resources/csl-styles/' changes from c1793d2..143464e Cite work by @ayaankazerouni Improve performance for loading files (#6332) Add ADR von JUnit vs. AssertJ (#6335) 'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option (#6330) Bump jurt from 6.3.2 to 6.4.3 (#6325) Bump unoil from 6.3.2 to 6.4.3 (#6320) Bump ridl from 6.3.2 to 6.4.3 (#6326) Bump classgraph from 4.8.69 to 4.8.71 (#6322) Bump flexmark from 0.61.6 to 0.61.16 (#6318) Bump richtextfx from 0.10.4 to 0.10.5 (#6319) Bump guava from 28.2-jre to 29.0-jre (#6323) Bump flexmark-ext-gfm-tasklist from 0.61.6 to 0.61.16 (#6327) Bump org.beryx.jlink from 2.17.5 to 2.17.7 (#6324) Improve performance massively by fixing a stupid binding mistake (#6316) Fixed missing paste command (#6313) Remove cache of auto completion results (#6310)

@ayaankazerouni

# By Tobias Diez (10) and others # Via dimitra-karadima (5) and others * upstream/master: (62 commits) Backward compatibility for 4.3.1 (#6296) Fix Export to clipboard Dialog icon (#6345) Refactor EntryEditorPreferences (#6245) Update label names Squashed 'src/main/resources/csl-locales/' changes from d0ee4d13c9..79845b087b Squashed 'src/main/resources/csl-styles/' changes from c1793d2..143464e Cite work by @ayaankazerouni Improve performance for loading files (#6332) Add ADR von JUnit vs. AssertJ (#6335) 'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option (#6330) Bump jurt from 6.3.2 to 6.4.3 (#6325) Bump unoil from 6.3.2 to 6.4.3 (#6320) Bump ridl from 6.3.2 to 6.4.3 (#6326) Bump classgraph from 4.8.69 to 4.8.71 (#6322) Bump flexmark from 0.61.6 to 0.61.16 (#6318) Bump richtextfx from 0.10.4 to 0.10.5 (#6319) Bump guava from 28.2-jre to 29.0-jre (#6323) Bump flexmark-ext-gfm-tasklist from 0.61.6 to 0.61.16 (#6327) Bump org.beryx.jlink from 2.17.5 to 2.17.7 (#6324) Improve performance massively by fixing a stupid binding mistake (#6316) ... # Conflicts: # build.gradle

@ayaankazerouni

…ionCaseInsensitive * upstream/master: (32 commits) Fix Export to clipboard Dialog icon (#6345) Refactor EntryEditorPreferences (#6245) Update label names Squashed 'src/main/resources/csl-locales/' changes from d0ee4d13c9..79845b087b Squashed 'src/main/resources/csl-styles/' changes from c1793d2..143464e Cite work by @ayaankazerouni Improve performance for loading files (#6332) Add ADR von JUnit vs. AssertJ (#6335) 'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option (#6330) Bump jurt from 6.3.2 to 6.4.3 (#6325) Bump unoil from 6.3.2 to 6.4.3 (#6320) Bump ridl from 6.3.2 to 6.4.3 (#6326) Bump classgraph from 4.8.69 to 4.8.71 (#6322) Bump flexmark from 0.61.6 to 0.61.16 (#6318) Bump richtextfx from 0.10.4 to 0.10.5 (#6319) Bump guava from 28.2-jre to 29.0-jre (#6323) Bump flexmark-ext-gfm-tasklist from 0.61.6 to 0.61.16 (#6327) Bump org.beryx.jlink from 2.17.5 to 2.17.7 (#6324) Improve performance massively by fixing a stupid binding mistake (#6316) Fixed missing paste command (#6313) ...

f6c778e Update emerald-harvard.csl (#6335) d6c6a16 Fix Brazilian quotes on chicago-author-date.csl (#6317) a1549b6 Update medizinische-hochschule-hannover.csl (#6330) da88073 Update journal-of-the-american-college-of-cardiology.csl (#6334) a520d8e Bump nokogiri from 1.13.9 to 1.13.10 (#6333) ba54b44 Update royal-society-of-chemistry.csl (#6328) 1378ba7 LUSEM: Remove full stop (#6332) 9e3cf89 Create interpreting.csl (#6254) bef74ed Create conservation-science-and-practice.csl (#6258) 9fb7eb7 Bug fixes triangle.csl (#6251) e6112ba Update ucl-university-college-apa.csl (#6250) 6dcba3a Update engineering-technology-and-applied-science-research.csl (#6247) 00fe4a2 Create constructivist-foundations.csl (#6243) 03ad71b Create les-mondes-du-travail.csl (#6234) a2bce86 Corrections based on author instructions (#6306) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: f6c778e

84dba23 Update international-union-of-crystallography.csl (#6279) 13dd9e8 Update zeitschrift-fur-deutsche-philologie.csl (#6340) d95b652 Create cahiers-mondes-anciens.csl (#6203) ded567c Create rassegna-degli-archivi-di-stato-bibliografia-generale.csl (#6275) 124777a Create scientific-online-letters-on-the-atmosphere.csl (#6261) 3c276e7 Create american-medical-association-no-url-alphabetical.csl (#6252) 595ad95 Bump mathieudutour/github-tag-action from 6.0 to 6.1 (#6287) 7008128 Create cambridge-a (#6336) 17e930c Update norsk-apa-manual-note.csl (#6338) b360859 Update norsk-apa-manual.csl (#6337) f6c778e Update emerald-harvard.csl (#6335) d6c6a16 Fix Brazilian quotes on chicago-author-date.csl (#6317) a1549b6 Update medizinische-hochschule-hannover.csl (#6330) da88073 Update journal-of-the-american-college-of-cardiology.csl (#6334) a520d8e Bump nokogiri from 1.13.9 to 1.13.10 (#6333) ba54b44 Update royal-society-of-chemistry.csl (#6328) 1378ba7 LUSEM: Remove full stop (#6332) 9e3cf89 Create interpreting.csl (#6254) bef74ed Create conservation-science-and-practice.csl (#6258) 9fb7eb7 Bug fixes triangle.csl (#6251) e6112ba Update ucl-university-college-apa.csl (#6250) 6dcba3a Update engineering-technology-and-applied-science-research.csl (#6247) 00fe4a2 Create constructivist-foundations.csl (#6243) 03ad71b Create les-mondes-du-travail.csl (#6234) a2bce86 Corrections based on author instructions (#6306) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 84dba23

HussainArif12 added 3 commits April 20, 2020 15:18

Name field now in focus whenever 'add subgroup' button selected

d54cdc4

Updated: Focuson Name Area instead of 'OK' button whenever user press…

6eecc15

…es 'Add subgroup'

Focus on name text area whenever user clicks on Add Subgroup

f4e1785

HussainArif12 changed the title ~~Hussain~~ 'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option Apr 20, 2020

calixtus requested changes Apr 20, 2020

View reviewed changes

Focus on name text area when OK button is pressed

3172b9d

HussainArif12 requested a review from calixtus April 20, 2020 13:18

calixtus approved these changes Apr 20, 2020

View reviewed changes

Siedlerchr reviewed Apr 20, 2020

View reviewed changes

Fixed changelog.md

94beba5

Siedlerchr approved these changes Apr 21, 2020

View reviewed changes

Siedlerchr merged commit dc1e339 into JabRef:master Apr 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option #6330

'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option #6330

HussainArif12 commented Apr 20, 2020 •

edited by Siedlerchr

Loading

calixtus left a comment

calixtus Apr 20, 2020

calixtus Apr 20, 2020

calixtus Apr 20, 2020

Siedlerchr commented Apr 20, 2020

calixtus left a comment

Siedlerchr Apr 20, 2020

HussainArif12 commented Apr 21, 2020

Siedlerchr commented Apr 21, 2020

		@@ -131,7 +131,7 @@ public void initialize() {
		autoGroupPersonsField.textProperty().bindBidirectional(viewModel.autoGroupPersonsFieldProperty());

		texGroupFilePath.textProperty().bindBidirectional(viewModel.texGroupFilePathProperty());

'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option #6330

'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option #6330

Conversation

HussainArif12 commented Apr 20, 2020 • edited by Siedlerchr Loading

calixtus left a comment

Choose a reason for hiding this comment

calixtus Apr 20, 2020

Choose a reason for hiding this comment

calixtus Apr 20, 2020

Choose a reason for hiding this comment

calixtus Apr 20, 2020

Choose a reason for hiding this comment

Siedlerchr commented Apr 20, 2020

calixtus left a comment

Choose a reason for hiding this comment

Siedlerchr Apr 20, 2020

Choose a reason for hiding this comment

HussainArif12 commented Apr 21, 2020

Siedlerchr commented Apr 21, 2020

HussainArif12 commented Apr 20, 2020 •

edited by Siedlerchr

Loading