Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple Unit Tests for #6207 #6240

Commits on Apr 4, 2020

  1. Unit tests improvement for JabRef#6207

    Add the following changes:
    -remove multiple assert statements in test cases
    -split each assert statement in different test methods with meaningful
    test names
    dimitra-karadima committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    b9c73fd View commit details
    Browse the repository at this point in the history
  2. Fix some problems

    Fix some encoding problems
    Fix merge conflict with the master branch
    dimitra-karadima committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    b37a921 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Fix merge conflict

    dimitra-karadima committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    fe9546d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2020

  1. Add more unit tests

    Add the following changes:
    -move tests from IntegrityCheckTest to the appropriate Test classes
    -remove multiple assert statements in different test methods
    -fix the capitalization in TitleCheckerTest
    dimitra-karadima committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    02e8f67 View commit details
    Browse the repository at this point in the history
  2. Solve some issues

    Change two failing tests to succesfull
    Remove one test
    dimitra-karadima committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    b204b6b View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Configuration menu
    Copy the full SHA
    0595351 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Rework the added tests

    Add the following changes:
    -Use checker.checkValue or checker.check instead of IntegrityCheckTest...
    -Split a method with multiple assertion methods in FileCheckerTest into three different with a simple assertion method
    -Rename a method in ASCIICharacterCheckerTest in order to use defined camel case
    dimitra-karadima committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    3a4f9d7 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Configuration menu
    Copy the full SHA
    c9320d4 View commit details
    Browse the repository at this point in the history
  2. Fix conflicts

    dimitra-karadima committed May 5, 2020
    Configuration menu
    Copy the full SHA
    ed2e7ea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc72c05 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Configuration menu
    Copy the full SHA
    3933821 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Rework IntegrityCheckTest and BibtexKeyCheckerTest

    Add the following changes:
    -Revert all methods from protected static to private
    -Change BibtexKeyCheckerTest in order not to use IntegrityCheckTest's methods
    -Add two tests methods that were moved to another class
    dimitra-karadima committed May 7, 2020
    Configuration menu
    Copy the full SHA
    ca9f2f4 View commit details
    Browse the repository at this point in the history
  2. Change JournalInAbbreviationListCheckerTest

    Due to recent merges to master the JournalAbbreviationRepository constructor changed so the creation of the object changes as well.
    dimitra-karadima committed May 7, 2020
    Configuration menu
    Copy the full SHA
    207b28f View commit details
    Browse the repository at this point in the history
  3. Remove @beforeeach from test classes

    Remove it wherever it was just creating objects
    dimitra-karadima committed May 7, 2020
    Configuration menu
    Copy the full SHA
    1544c73 View commit details
    Browse the repository at this point in the history
  4. Rework EditionCheckerTest

    Remove unnecessary BibEntry initialization and import
    dimitra-karadima committed May 7, 2020
    Configuration menu
    Copy the full SHA
    16129ca View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. Fix checkstyle

    Rework test class because checkstyle is failing
    dimitra-karadima committed May 9, 2020
    Configuration menu
    Copy the full SHA
    870ce0d View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Fix checkstyle again

    Fix because instance variable definition was in wrong order.
    dimitra-karadima committed May 11, 2020
    Configuration menu
    Copy the full SHA
    8529050 View commit details
    Browse the repository at this point in the history
  2. Rework PersonNamesCheckersTest

    Change from multiple test methods to two parameterized with @MethodSource
    dimitra-karadima committed May 11, 2020
    Configuration menu
    Copy the full SHA
    193d420 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Update PersonNamesCheckerTest

    Change the return type of two methods from String[] to Stream<String> since it is more readable.
    dimitra-karadima committed May 12, 2020
    Configuration menu
    Copy the full SHA
    08afd12 View commit details
    Browse the repository at this point in the history
  2. Update IntegrityCheckTest

    Add the following changes:
    -Add Javadoc
    -Rewrite testAuthorNameChecks with @MethodSource
    dimitra-karadima committed May 12, 2020
    Configuration menu
    Copy the full SHA
    4eae95a View commit details
    Browse the repository at this point in the history