Issue #5223 #5266
Merged
Issue #5223 #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far. Please add a changelog entry For the next time please do not enter the issue number in the title of the PR, because github can't link it then. If you write Closes #xxxx or Fixes #xxx then the issue will be automatically closed when the PR is merged. |
tobiasdiez
reviewed
Sep 2, 2019
| @@ -177,8 +177,22 @@ | |||
| .withImportantFields(StandardField.MONTH, StandardField.YEAR) | |||
| .build(); | |||
|
|
|||
|
|
|||
| private static final BibEntryType SOFTWARE = new BibEntryTypeBuilder() | |||
There was a problem hiding this comment.
I think software and dataset are specific to biblatex and thus shouldn't be added here for the bibtex entry types.
tobiasdiez
approved these changes
Sep 3, 2019
Siedlerchr
approved these changes
Sep 9, 2019
|
Which biblatex styles support |
|
biblatex-bath does (https://ctan.org/pkg/biblatex-bath) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #5223
Add @software and @dataset entrytype as an option in the Biblatex and Bibtex. Add fields eventitle, eventdate and venue to @Unpublished entry type. I used the MISC set of fields to supplement Software and DataSet, couldn't find documentation about specific fields that should be included in @software and @dataset entry type.