Add LaTeX citations tab to the entry editor

[davidemdot]

Here is an update for the LaTeX integration project. It adds a new tab to the entry editor (can be disabled in preferences), and also update EntryEditor.java to start using PreferencesService.

TODO:

• Rename feature according to Rename "LaTeX references search"  #5135
• Improve the exception handling
• Update CHANGELOG.md

---

• Change in CHANGELOG.md described
• Tests created for changes
• Manually tested changed features in running JabRef
• Screenshots added in PR description (for bigger UI changes)
• Ensured that the git commit message is a good one
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[Siedlerchr]

good wise lgtm so far for me

[tobiasdiez]

Nice work! The quality of the code is really improving from time to time!
I've a few comments, but nothing serious.

[tobiasdiez]

I think the cleanest solution would be to introduce a CitationsDisplay control that completely encapsulates the display of a list of citations and would replace the ListView<CitationViewModel> citationListView. See for example here: https://docs.oracle.com/javafx/2/fxml_get_started/custom_control.htm#BABIDAHI (only don't use FXML and replace the textProperty by a ObservableList<Citations>).
The strategy would then be to replace the citationListView in the fxml by the CitationsDisplay control and only keep the first line in (the other lines should go to the CitationsDisplay class):

jabref/src/main/java/org/jabref/gui/texparser/ParseTexResultView.java

Lines 43 to 46 in 34713f5

	citationListView.setItems(viewModel.getCitationListByReference());
	new ViewModelListCellFactory<CitationViewModel>()
	.withGraphic(citation -> citation.getDisplayGraphic(basePath, Optional.of(citationListView.getWidth() - 50)))
	.install(citationListView);

But the current solution is also ok (although the separation between UI-Controls and UI-Logic is not that clear).

[davidemdot]

I think the cleanest solution would be to introduce a CitationsDisplay control that completely encapsulates the display of a list of citations and would replace the ListView<CitationViewModel> citationListView.

At first, I started doing it in that way, but it did not work properly. Because the current version has been more tested and looks stable, I thought it would be a good idea to merge this feature as soon as possible for starting to get feedback from users, and then change this point (and others) with an early patch.