Revise maintable #452
Revise maintable #452
Conversation
|
Awesome. |
|
Before I invest much time to fix it... @JabRef/developers Are we dropping support for the "PDF/PS" column in the main table? In this column potential contents of the "legacy fields" |
|
Yes, support has been dropped for pdf/ps fields all over the place, we should do this as well for the main table. |
|
👍 for removing these legacy columns. Could someone create a FAQ entry (in htdocs) or send me a plain FAQ on how to mimic that behavior with the "special columns"? |
|
Very nice PR. With this, we already have a 3.1 :) |
@simonharrer Mhmm... but this gui stuff is quite unnerving 😉 |
|
And we already have issues with the pdf/ps columns, which no longer seem to work correctly: #498 |
| } else if (i == URL_COL) { | ||
| comparators.add(new IconComparator(new String[]{"url"})); | ||
| comparators.add(new IconComparator(Arrays.asList("url"))); |
There was a problem hiding this comment.
You could use Collections.singletonList instead.
matthiasgeiger
force-pushed
the
revise-maintable
branch
from
e846c55
to
9f5e3fb
Compare
|
Just rebased - from my point of view the current state is good enough to be merged into master. |
matthiasgeiger
added
the
status: ready-for-review
| this.bibtexFields = Collections.emptyList(); | ||
| this.isIconColumn = false; | ||
| this.iconLabel = null; | ||
| this.database = null; |
There was a problem hiding this comment.
Idea: use optional instead to avoid null checks.
|
👍 |
Complete check and rewrite of MainTable and related classes
This will fix and implement:
[ ] Allow storing position of specialfield columnspostponed to another PR[ ] Main Table: Right click on DOI field: Allow copying DOI #490postponed[ ] Think about "must be implemented "vernünftig (matthias)" "Entry table -> fit table horizontally ...."" from the minutespostponed