Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docbook exporter #4108

Closed

Conversation

johannes-manner
Copy link
Collaborator

@johannes-manner johannes-manner commented Jun 6, 2018

References #3838.

The problem are LaTeX commands, which are not resolved before executing special formatters for all fields. Therefore the presented solution is quite easy, but I cannot assess, if this solution has any side effects or if there are cases, where the LaTeX command should be also present after formatting.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef

@@ -186,4 +186,4 @@ private static void configureProxy(ProxyPreferences proxyPreferences) {
Authenticator.setDefault(new ProxyAuthenticator());
}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the newline at the end of the file. Just unstage this file from the commit.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the impact of removing latex commands at the all layouter in general.

Aren't there any test cases?

@tobiasdiez
Copy link
Member

Since there are formatters that need the latex commands to be present (e.g. because the translate latex to unicode), this solution sadly does not work. As this PR is stale for quite some time now, I'll close it now. Feel free to update the code and reopen the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants