Improve date parsing #2731
Merged
Improve date parsing #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
reviewed
Apr 13, 2017
| * - "uuuu.M.d" (covers 2015.1.15) | ||
| * The code is essentially taken from http://stackoverflow.com/questions/4024544/how-to-parse-dates-in-multiple-formats-using-simpledateformat. | ||
| */ | ||
| public static Optional<Date> parse(String dateString) { |
There was a problem hiding this comment.
Theoretically we should support all allowed date formats from biblatex: EDTF format
2.3.8 Date and Time Specifications
A while ago I looked into that and found that there is no easy way to support all in java.
There was a problem hiding this comment.
I have moved this into issue #2753
Siedlerchr
reviewed
Apr 13, 2017
| */ | ||
| public enum Month { | ||
|
|
||
| JANUARY("January", "jan", "01", "#jan#", 0), |
There was a problem hiding this comment.
With the JAVA 8 Date Time changes, month now are 1-12 and no longer 0-11
|
In general LGTM |
1 task
tobiasdiez
commented
Apr 17, 2017
| @@ -5,7 +5,7 @@ @Article{Orlowski;2011 | |||
| title = {Application of Ontology In the ITIL Domain}, | |||
| journal = {Information Systems Architecture and Technology: Service Oriented Networked Systems}, | |||
| year = {2011}, | |||
| month = {mar}, | |||
| month = {03}, | |||
There was a problem hiding this comment.
Isn't month = mar the correct format for BibTex?!
There was a problem hiding this comment.
It's only, because many styles define the string mar. At least this is what I read from the discussion at https://tex.stackexchange.com/q/70455/9075.
koppor
removed
the
status: ready-for-review
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves a few small things about the date parsing:
NormalizeDateFormatter,BibEntryand in some importer. All these code snippets are now merged in a newDateclass. This resulted in more robust code and slightly improved parsing performance.MonthUtilclass is now an enum with a few static helper methods.gradle localizationUpdate?