Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OrdinalsToSuperscriptFormatter from recommended biblatex save actions #2601

Merged
merged 2 commits into from
Mar 5, 2017

Conversation

lenhard
Copy link
Member

@lenhard lenhard commented Mar 2, 2017

Fixes #2596

The LatexToUnicode is conflicting with the OrdinalsToSuperscriptFormatter but both are recommended for the same fields for biblatex. This PR removes the latter. Since biblatex is usually used together with UTF-8 and Unicode conversion should be sufficient.

@lenhard lenhard added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 2, 2017
@koppor
Copy link
Member

koppor commented Mar 2, 2017

I see that this is an issue. The initial idea is as follows:

  1. No BibEntry should contain LaTeX encoded umlauts
  2. Each BibEntry should use superscripts whereever possible.

Why is this not possible any more? Why can't I have properly formatted BibEntries with JabRef any more?

@Siedlerchr
Copy link
Member

That's really weird. I never had problems with that setting

@koppor
Copy link
Member

koppor commented Mar 2, 2017

Yeah, I worked with that for ages. 🌞

@Siedlerchr
Copy link
Member

Is this maybe due to the new lib?

@lenhard
Copy link
Member Author

lenhard commented Mar 2, 2017

Yes, I would expect that this is due to the new lib. I assume that it leads to the following:

  1. Ordinals formatter converts 2nd to 2\textsuperscript{nd}
  2. Latex formatter converts 2\textsuperscript{nd} to 2ⁿᵈ
  3. Ordinals formatter interprets 2ⁿᵈ as 2nd and converts it to 2\textsuperscript{nd}
  4. And so on

I might be wrong though, I did not debug this.

@Siedlerchr @koppor: Do you have problems with it now? What would you recommend instead?

@koppor
Copy link
Member

koppor commented Mar 5, 2017

When using the defaults in the "Cleanup entries" dialog, everything works fine.

grafik

Maybe, it is possible to have different defaults for save actions and for cleanup? I really need that functionality.

@lenhard
Copy link
Member Author

lenhard commented Mar 5, 2017

@koppor The problem are the defaults for biblatex, not for BibTeX, which are depicted in your screenshot above.

An alternative solution, and maybe even a better one, might be to have the ordinals formatter correctly recognize 2ⁿᵈ as ordinals, so that it does not try to replace that. Should be doable, but right now I cannot make any promises time-wise. So, if anybody wants to take this over, be my guest.

@koppor
Copy link
Member

koppor commented Mar 5, 2017

I am not sure whether all unicode fonts support 2ⁿᵈ. Therefore, I really like the idea to have the ordinals formatter recognize that.

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really that important to have "ordinals-to-superscript" as default to invest more energy into it? I think @lenhard's solution is fine.

You can choose between

  • Everything in unicode, then you would want 2ⁿᵈ similar to ℚΔ∘ΞΛΩ -> Latex to Unicode
  • Everything in latex, then it would be 2\textsuperscript{nd} or even better \nth{2} using the nth package but also \alpha, \beta, \in ... -> Unicode to Latex + Ordinals to Latex

@matthiasgeiger
Copy link
Member

I second Jörgs and Tobias' opinion...

@koppor koppor merged commit 38fddd1 into master Mar 5, 2017
@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 5, 2017
@tobiasdiez tobiasdiez deleted the fix-biblatex-recommendations branch March 6, 2017 11:30
Siedlerchr added a commit that referenced this pull request Mar 7, 2017
* upstream/master: (91 commits)
  fixed #2613 (#2623)
  Add MathSciNet as ID-based fetcher (#2621)
  Add icon + color and description to groups (#2612)
  Fixed wrong logger import (#2618)
  Cleanup window has a scrollbar now. (#2614)
  Added the locale to a newly created class
  Move ExportComparator and CustomExportList to the correct package (only used in preferences)
  Fixes displaying of Mr DLib recommendations (#2616)
  Fix title-related key patterns in BibtexKeyPatternUtil (#2610)
  Remove OrdinalsToSuperscriptFormatter from recommended biblatex save actions (#2601)
  Update pgjdbc to new major version
  Update Dependenices String Similary log4j wiremock mockito
  Fix exception when parsing groups which contain a top level group (#2611)
  Add "Remove group and subgroups" option (#2587)
  Fix #1104: group selection is preserved under tab change
  Fix several File Cleanup + Rename issues  (#2415)
  Fixed a small error in the code comments
  Implement #1904: filter groups (#2588)
  Braces checking followup (#2598)
  Improve braces checking (#2593)
  ...
@koppor koppor mentioned this pull request Apr 16, 2017
@koppor
Copy link
Member

koppor commented Apr 17, 2017

I really like the ordinals-to-suprscript formatter as it provides great formatted bibliographies.

People write "2nd conference on something", which should appear as "2ⁿᵈ conference on something" in the proceedings. If I understand the fix correctly, biblatex papers won't have the superscript (more or less) automatically from now on.

Since most publishers use bibtex, the solution for me is to have an unclean personal biblatex file and always to the bibtex conversion when working on a paper. The superscript will be injected when copying the entry to the paper by a cleanup..

Refs #160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants