Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FX] Review abbreviations dialog #2383

Merged
merged 3 commits into from
Dec 14, 2016
Merged

[FX] Review abbreviations dialog #2383

merged 3 commits into from
Dec 14, 2016

Conversation

tobiasdiez
Copy link
Member

Final review-PR towards #2290.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 14, 2016
@Siedlerchr
Copy link
Member

Regarding the file dialog, it would be cool to use our File Dialog class, see #1711
It could simply be replaced with the javafx version
Otherwise Code looks good

@tobiasdiez tobiasdiez merged commit 4f4c6a0 into javafx Dec 14, 2016
@tobiasdiez tobiasdiez deleted the reviewAbbreviations branch December 14, 2016 22:00
@tobiasdiez tobiasdiez mentioned this pull request Dec 14, 2016
Merged
22 tasks
@tobiasdiez
Copy link
Member Author

Good point! Follow-up PR #2384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @Siedlerchr