Improvements to the JavaFX Error Console #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boceckts
added
stupro
status: ready-for-review
tobiasdiez
requested changes
Nov 1, 2016
| @@ -35,10 +45,29 @@ | |||
| private void initialize() { | |||
| listViewStyle(); | |||
| allMessages.itemsProperty().bind(errorViewModel.allMessagesDataproperty()); | |||
| allMessages.scrollTo(errorViewModel.allMessagesDataproperty().getSize() - 1); | |||
There was a problem hiding this comment.
Let the ViewModel decide to which entry one should scroll (i.e. introduce errorViewModel.scrollTo property, which should be bound to size() - 1). If you feel like I'm too pedantic here, just ignore my remark 😄 .
There was a problem hiding this comment.
In my opinion this is not part of the model.. :)
| KeyBindingPreferences keyPreferences = Globals.getKeyPrefs(); | ||
| if (keyPreferences.checkKeyCombinationEquality(KeyBinding.COPY, event)) { | ||
| ObservableList<LogEvent> selectedEntries = allMessages.getSelectionModel().getSelectedItems(); | ||
| if (!selectedEntries.isEmpty()) { |
There was a problem hiding this comment.
Try to reuse the copyLog method (i.e. create an overload which accepts a list of LogEvents)
tobiasdiez
removed
the
status: ready-for-review
|
Ok, rebase and merge. |
boceckts
force-pushed
the
errorConsoleCopy
branch
from
f3794d2
to
a5a404c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log messages in the list view of the error console can now be selected and copied. The error message will also automatically scroll to the newest log message. Refs #2210