Integrity hotkey #2198
Integrity hotkey #2198
Conversation
tschechlovdev
added
status: ready-for-review
| @@ -13,6 +13,7 @@ | |||
| BACK("Back", Localization.lang("Back"), "alt LEFT"), | |||
| CLEANUP( | |||
| "Cleanup", Localization.lang("Cleanup entries"), "F8"), | |||
| CHECK_INTEGRITY("Check integrity", Localization.lang("Check integrity"), "ctrl F8"), | |||
There was a problem hiding this comment.
What was our last consensus about showing menu entries in the hotkey dialog? I think, I opted for using Localization.lang, but we might have decided to re-translate these entries. @boceckts Do you remember? I think, we had the discussion. @tobiasdiez Is that documented in our CodeHowTo in the Wiki?
There was a problem hiding this comment.
The thing I rember was about the keybinding category where we should use Localization.menuTitle as you wrote in #1390 (comment). This affects only the javafx branch so far. Other than that I don't remeber a discussion about the menu entries in the hotkey dialog. 🤔
There was a problem hiding this comment.
In the KeyBinding.java only Localization.lang gets used. So I guess it must be right.
| @@ -66,6 +66,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| - [koppor#61](https://github.com/koppor/jabref/issues/61) Display gray background text in "Author" and "Editor" field to assist newcomers | |||
| - Updated Vietnam translation | |||
| - Added greyed-out suggestion for `year`/`date`/`url` fields | |||
| - [#1908] (https://github.com/JabRef/jabref/issues/1908) Add a shortcut for check integrity | |||
There was a problem hiding this comment.
Why is the new shortcut not listed here?
There was a problem hiding this comment.
Why is there a space between the issue and the link?
There was a problem hiding this comment.
Must have hapened out of habit, I'l fix your comments.
| @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover | |||
| Firstname_Lastname= | |||
|
|
|||
| This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).= | |||
|
|
|||
| Check_integrity=?????_??????? | |||
There was a problem hiding this comment.
This doesn't look right here?
|
Thanx. So, please, no copy'n'paste solutions here and useage of .menuTitle
|
|
I changed it to menuTitle and removed the unused keys. |
The "Check integrity"-action seems to be in need of a hotkey. (See #1908) I used
CTRL + F8for this action, because F8 is currently used to Cleanup entries. These 2 functions seem to be related so it would make sense to group them.gradle localizationUpdate?