Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Groups JavaFX Rework #1438

Closed
wants to merge 8 commits into from
Closed

Conversation

tobiasdiez
Copy link
Member

I played around a bit with JavaFX and tried to redesign the group pane.
The result:
untitled

Question: so far it it is just the ui with dummy test data and without any interaction. If I now start to port everything to JavaFX then the JavaFX branch will diverge immensely from the master. Should I stop here and leave it as a prototype for now or should I finish it?

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)

@simonharrer
Copy link
Contributor

I vote for leaving it for now and focusing on the current system instead.

We try to wait for the feedback on using JavaFX from the stupro to decide how much effort a change would be.

@boceckts
Copy link
Contributor

In my opinion there is no problem in partly switching to the new JavaFX technology. Either you embedd JavaFX elements in swing using JFXPanel as shown here or you port whole dialogs as shown in #1390 . Looking at the code of both pull requests it is quite easy to separate the JavaFX code from the core swing code.
I also think it looks much better than the more out dated swing ui and is much more customizable. Although I wouldn't change the style of the new elements too much for the beginning as there could be a very inconsitent look and feel against the swing components.

groupTree.setRoot(root);
}

public static class CheckBoxTreeTableRowSkin<S> extends TreeTableRowSkin<S> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New class should be in a new file

@koppor
Copy link
Member

koppor commented Sep 7, 2016

How much work is it to get this merged into javafx? Does the current work on grouping influence this PR?

@tobiasdiez
Copy link
Member Author

Around 1-2 weeks for a working minimal version (display of the groups tree and adding/editing of groups) but a few more until all current features are included.

@koppor
Copy link
Member

koppor commented Oct 12, 2016

I just close this PR as we currently focus on other issues. We will reopen as soon as we continue working on it.

@koppor koppor closed this Oct 12, 2016
@AEgit
Copy link

AEgit commented Nov 11, 2016

Any news on this? I would still be quite interested in the JavaFX rework, especially since this was supposed to provide the functionality proposed in #1904
The latter would be quite helpful when dealing with many (~1000) groups.

@matthiasgeiger
Copy link
Member

We will now continue with our efforts to move on to JavaFX (there are already some dialogs implemented).

However, I don't know if and when @tobiasdiez will be able to continue on this.

@AEgit
Copy link

AEgit commented Nov 21, 2016

Thanks - hmm, I see. Do you think it would be necessary to reopen this issue (just to raise awareness)? Or is it all right the way it's now?

@koppor koppor removed the on-hold label Feb 15, 2017
@koppor koppor changed the base branch from javafx to master February 15, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants