Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save unlinked local files dialog prefs #11493

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Save unlinked local files dialog prefs #11493

merged 4 commits into from
Jul 16, 2024

Conversation

kataramarina
Copy link
Contributor

@kataramarina kataramarina commented Jul 15, 2024 •
edited by koppor
Loading

Added new check in the dialog that allows to save selected options of the dialog through the work and in the propgram preferences.
image

Closes #11439

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor
koppor requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good.

Please just remove the option to enable storing --> It should always be stored. (I know, the issue asked otherwise, that slipped through while making it a good first issue)

src/main/java/org/jabref/gui/externalfiles/DateRange.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/externalfiles/ExternalFileSorter.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialog.fxml Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogView.java Outdated Show resolved Hide resolved
koppor
koppor approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! PR awaits a second review, since I am not fully into the preferences handling.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 16, 2024
Siedlerchr
Siedlerchr approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! lgtm

@Siedlerchr Siedlerchr added this pull request to the merge queue Jul 16, 2024
Merged via the queue into JabRef:main with commit 410db8a Jul 16, 2024
22 checks passed
Siedlerchr added a commit to subhramit/jabref that referenced this pull request Jul 19, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into oo-architecture
85873c2 
* upstream/main:
  Fix NPE when saving preferences (JabRef#11509)
  Switch to stream-based loading (JabRef#11479)
  Save unlinked local files dialog prefs (JabRef#11493)
  Add minimal support for biblatex data annotations (JabRef#11506)
  Fix handling of relative-file storage and auto linking (JabRef#11492)
  New Crowdin updates (JabRef#11504)
  Add missing issue numbers
  CSL4LibreOffice - A [GSoC '24] (JabRef#11477)
  Bump src/main/resources/csl-styles from `b2be5ae` to `fd6cb3e` (JabRef#11501)
  Bump gittools/actions from 1.1.1 to 1.2.0 (JabRef#11500)
  Bump com.kohlschutter.junixsocket:junixsocket-core from 2.9.1 to 2.10.0 (JabRef#11498)
  Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 (JabRef#11499)
  Bump org.jsoup:jsoup from 1.17.2 to 1.18.1 (JabRef#11497)
  Bump com.kohlschutter.junixsocket:junixsocket-mysql from 2.9.1 to 2.10.0 (JabRef#11496)
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.14.0 to 2.15.0 (JabRef#11495)
  FAQ updates (JabRef#11486)
  Update Gradle Wrapper from 8.8 to 8.9.
  Fix Chocolate.bib (JabRef#11491)

# Conflicts:
#	src/main/java/org/jabref/gui/openoffice/OOBibBase.java
#	src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java
#	src/main/java/org/jabref/gui/openoffice/StyleSelectDialogView.java
#	src/main/java/org/jabref/gui/openoffice/StyleSelectDialogViewModel.java
#	src/main/java/org/jabref/preferences/JabRefPreferences.java
@Siedlerchr Siedlerchr mentioned this pull request Jul 31, 2024
Closed
2 tasks
Siedlerchr added a commit that referenced this pull request Jul 31, 2024
@Siedlerchr
Fix default value of unlinked files preferences
d041dbd 
Save configuration on dialog exit

Fixes #11540

Follow up to #11493
Siedlerchr added a commit that referenced this pull request Jul 31, 2024
@Siedlerchr
Fix default value of unlinked files preferences
9e7bde3 
Save configuration on dialog exit

Fixes #11540

Follow up to #11493
@Siedlerchr Siedlerchr mentioned this pull request Jul 31, 2024
Merged
6 tasks
@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 31, 2024 •
edited
Loading

@kataramarina For your info, there was a little bug which resulted in an exception which prevented the opening of the dialog

See #11553

github-merge-queue bot pushed a commit that referenced this pull request Jul 31, 2024
@Siedlerchr
Fix find unlinked files (#11553)
7be96c6 
* Fix default value of unlinked files preferences


Save configuration on dialog exit

Fixes #11540

Follow up to #11493

* use default as fallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unlinked Local File dialog: remembering options
3 participants
@kataramarina @Siedlerchr @koppor