-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save unlinked local files dialog prefs #11493
Save unlinked local files dialog prefs #11493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, looks good.
Please just remove the option to enable storing --> It should always be stored. (I know, the issue asked otherwise, that slipped through while making it a good first issue)
src/main/java/org/jabref/gui/externalfiles/ExternalFileSorter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialog.fxml
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogView.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! PR awaits a second review, since I am not fully into the preferences handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! lgtm
* upstream/main: Fix NPE when saving preferences (JabRef#11509) Switch to stream-based loading (JabRef#11479) Save unlinked local files dialog prefs (JabRef#11493) Add minimal support for biblatex data annotations (JabRef#11506) Fix handling of relative-file storage and auto linking (JabRef#11492) New Crowdin updates (JabRef#11504) Add missing issue numbers CSL4LibreOffice - A [GSoC '24] (JabRef#11477) Bump src/main/resources/csl-styles from `b2be5ae` to `fd6cb3e` (JabRef#11501) Bump gittools/actions from 1.1.1 to 1.2.0 (JabRef#11500) Bump com.kohlschutter.junixsocket:junixsocket-core from 2.9.1 to 2.10.0 (JabRef#11498) Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 (JabRef#11499) Bump org.jsoup:jsoup from 1.17.2 to 1.18.1 (JabRef#11497) Bump com.kohlschutter.junixsocket:junixsocket-mysql from 2.9.1 to 2.10.0 (JabRef#11496) Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.14.0 to 2.15.0 (JabRef#11495) FAQ updates (JabRef#11486) Update Gradle Wrapper from 8.8 to 8.9. Fix Chocolate.bib (JabRef#11491) # Conflicts: # src/main/java/org/jabref/gui/openoffice/OOBibBase.java # src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java # src/main/java/org/jabref/gui/openoffice/StyleSelectDialogView.java # src/main/java/org/jabref/gui/openoffice/StyleSelectDialogViewModel.java # src/main/java/org/jabref/preferences/JabRefPreferences.java
@kataramarina For your info, there was a little bug which resulted in an exception which prevented the opening of the dialog See #11553 |
Added new check in the dialog that allows to save selected options of the dialog through the work and in the propgram preferences.
![image](https://private-user-images.githubusercontent.com/35892754/348598370-688548a0-3f05-4c8e-aa3b-56a96d44addd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwOTM1MzAsIm5iZiI6MTcyNDA5MzIzMCwicGF0aCI6Ii8zNTg5Mjc1NC8zNDg1OTgzNzAtNjg4NTQ4YTAtM2YwNS00YzhlLWFhM2ItNTZhOTZkNDRhZGRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE5VDE4NDcxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFmY2JkMmFiNTUwYTU2MjEwNjg1M2YzYzdkMzdkOTRiZDRiYjcxNjNjYjkwMDE1YmQzNDRlMjJhNjkwYmUzMTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.r8By3agyZ7TAtC-xZXUjVLkbCAvqW3J04VIAISs0ct0)
Closes #11439
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)